lib,pimd: don't use strcpy #6256

qlyoung · 2020-04-18T00:01:10Z

stop
using
strcpy

Signed-off-by: Quentin Young qlyoung@cumulusnetworks.com

>:( Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

LabN-CI · 2020-04-18T00:58:10Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6256 `96e4329`
Date	04/17/2020
Start	20:32:18
Finish	20:58:05
Run-Time	25:47
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-04-17-20:32:18.txt
Log	autoscript-2020-04-17-20:33:15.log.bz2
Memory	477 487 425

For details, please contact louberger

NetDEF-CI · 2020-04-18T01:42:38Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11936/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11936/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200417-06-g96e43299b-0 (missing) -> 7.4-dev-20200417-06-g96e43299b-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200417-06-g96e43299b-0 (missing) -> 7.4-dev-20200417-06-g96e43299b-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200417-06-g96e43299b-0 (missing) -> 7.4-dev-20200417-06-g96e43299b-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200417-06-g96e43299b-0 (missing) -> 7.4-dev-20200417-06-g96e43299b-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200417-06-g96e43299b-0 (missing) -> 7.4-dev-20200417-06-g96e43299b-0~deb10u1

NetDEF-CI · 2020-04-18T01:42:45Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11938/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotest tests on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-11938/test

Topology Tests failed for Topotest tests on Ubuntu 16.04 i386:

RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-04-18 02:44:09,377 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/bgp.py", line 159, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 240, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 397, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 4: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-04-18 02:44:09,675 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/bgp.py", line 159, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 240, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 397, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp 



*** defaultIntf: warning: r1 has no interfaces
2020-04-18 03:12:27,125 ERROR: '_bgp_has_routes' failed after 38.63 seconds
2020-04-18 03:13:37,982 ERROR: ******************************************************************************
2020-04-18 03:13:37,982 ERROR: Test Target Summary                                                  Pass Fail
2020-04-18 03:13:37,982 ERROR: ******************************************************************************
2020-04-18 03:13:37,983 ERROR: FILE: scripts/adjacencies.py
2020-04-18 03:13:37,983 ERROR: 17   r4     PE->PE3 (loopback) ping +0.00 secs                       0    1
2020-04-18 03:13:37,983 ERROR: See /tmp/topotests/bgp_instance_del_test.test_bgp_instance_del_test/output.log for details of errors
2020-04-18 03:13:37,983 ERROR: assert failed at "bgp_instance_del_test.test_bgp_instance_del_test/test_adjacencies": 1 tests failed
2020-04-18 03:18:22,919 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1509, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 240, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 397, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2020-04-18 03:18:23,071 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1509, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 240, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 397, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2020-04-18 03:18:23,206 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1509, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 240, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 397, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2020-04-18 03:18:23,344 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1509, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 240, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 397, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2020-04-18 03:20:25,572 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1509, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 240, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 397, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit  



RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-04-18 03:27:26,035 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-04-18 03:27:28,087 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-04-18 03:27:34,248 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11938/artifact/TOPOI386/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Debian 9 deb pkg check
Topology tests on Ubuntu 16.04 amd64
Fedora 29 rpm pkg check
IPv4 protocols on Ubuntu 14.04
Ubuntu 12.04 deb pkg check
Addresssanitizer topotests part 3
Static analyzer (clang)
Topology tests on Ubuntu 18.04 amd64
IPv6 protocols on Ubuntu 14.04
Ubuntu 16.04 deb pkg check
CentOS 7 rpm pkg check
Debian 10 deb pkg check
Addresssanitizer topotests part 1
IPv4 ldp protocol on Ubuntu 16.04
Ubuntu 14.04 deb pkg check
Addresssanitizer topotests part 2
Debian 8 deb pkg check

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotest tests on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-11938/test

Topology Tests failed for Topotest tests on Ubuntu 16.04 i386:

RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-04-18 02:44:09,377 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/bgp.py", line 159, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 240, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 397, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 4: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-04-18 02:44:09,675 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/bgp.py", line 159, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 240, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 397, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp 



*** defaultIntf: warning: r1 has no interfaces
2020-04-18 03:12:27,125 ERROR: '_bgp_has_routes' failed after 38.63 seconds
2020-04-18 03:13:37,982 ERROR: ******************************************************************************
2020-04-18 03:13:37,982 ERROR: Test Target Summary                                                  Pass Fail
2020-04-18 03:13:37,982 ERROR: ******************************************************************************
2020-04-18 03:13:37,983 ERROR: FILE: scripts/adjacencies.py
2020-04-18 03:13:37,983 ERROR: 17   r4     PE->PE3 (loopback) ping +0.00 secs                       0    1
2020-04-18 03:13:37,983 ERROR: See /tmp/topotests/bgp_instance_del_test.test_bgp_instance_del_test/output.log for details of errors
2020-04-18 03:13:37,983 ERROR: assert failed at "bgp_instance_del_test.test_bgp_instance_del_test/test_adjacencies": 1 tests failed
2020-04-18 03:18:22,919 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1509, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 240, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 397, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2020-04-18 03:18:23,071 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1509, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 240, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 397, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2020-04-18 03:18:23,206 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1509, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 240, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 397, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2020-04-18 03:18:23,344 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1509, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 240, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 397, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2020-04-18 03:20:25,572 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1509, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 240, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 397, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit  



RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-04-18 03:27:26,035 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-04-18 03:27:28,087 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-04-18 03:27:34,248 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11938/artifact/TOPOI386/ErrorLog/log_topotests.txt

Report for csv.c | 16 issues
===============================================
< ERROR: strcat() is error-prone; please use strlcat() if possible#532: FILE: /tmp/f1-21499/csv.c:532:
---
> ERROR: strcpy() is error-prone; please use strlcpy()#422: FILE: /tmp/f2-21499/csv.c:422:
> +	strcpy(rec->record, in_rec->record);
> 
> ERROR: strcat() is error-prone; please use strlcat() if possible#530: FILE: /tmp/f2-21499/csv.c:530:
62c65
< ERROR: strcat() is error-prone; please use strlcat() if possible#542: FILE: /tmp/f1-21499/csv.c:542:
---
> ERROR: strcat() is error-prone; please use strlcat() if possible#540: FILE: /tmp/f2-21499/csv.c:540:
65c68
< WARNING: strncpy() is error-prone; please use strlcpy() if possible, or memcpy()#591: FILE: /tmp/f1-21499/csv.c:591:
---
> WARNING: strncpy() is error-prone; please use strlcpy() if possible, or memcpy()#589: FILE: /tmp/f2-21499/csv.c:589:
69c72
< #644: FILE: /tmp/f1-21499/csv.c:644:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11938/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200418-00-g1120b9596-0 (missing) -> 7.4-dev-20200418-00-g1120b9596-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200418-00-g1120b9596-0 (missing) -> 7.4-dev-20200418-00-g1120b9596-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200418-00-g1120b9596-0 (missing) -> 7.4-dev-20200418-00-g1120b9596-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200418-00-g1120b9596-0 (missing) -> 7.4-dev-20200418-00-g1120b9596-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200418-00-g1120b9596-0 (missing) -> 7.4-dev-20200418-00-g1120b9596-0~deb10u1

LabN-CI · 2020-04-18T01:52:35Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	Complete
Date	04/05/2020
Start	21:26:31
Finish	21:50:56
Run-Time	24:25
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	autoscript-2020-04-05-21:26:31.txt
Log	autoscript-2020-04-05-21:26:31.log.bz2
Memory	451 496 427
SUCCESS git merge/6256 `1120b95`	Complete
04/17/2020	03/23/2020
21:26:32	21:26:32
21:52:27	21:50:54
25:55	24:22
1815	1815
1815	1815
0	0
0	0
0	0
vncregress-2020-04-17-21:26:32.txt	autoscript-2020-03-23-21:26:32.txt
autoscript-2020-04-17-21:27:30.log.bz2	autoscript-2020-03-23-21:26:32.log.bz2
472 473 425	490 495 418

For details, please contact louberger

eqvinox · 2020-04-18T15:04:13Z

CI:rerun

NetDEF-CI · 2020-04-18T16:37:53Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11941/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for csv.c | 16 issues
===============================================
< ERROR: strcat() is error-prone; please use strlcat() if possible#532: FILE: /tmp/f1-22511/csv.c:532:
---
> ERROR: strcpy() is error-prone; please use strlcpy()#422: FILE: /tmp/f2-22511/csv.c:422:
> +	strcpy(rec->record, in_rec->record);
> 
> ERROR: strcat() is error-prone; please use strlcat() if possible#530: FILE: /tmp/f2-22511/csv.c:530:
62c65
< ERROR: strcat() is error-prone; please use strlcat() if possible#542: FILE: /tmp/f1-22511/csv.c:542:
---
> ERROR: strcat() is error-prone; please use strlcat() if possible#540: FILE: /tmp/f2-22511/csv.c:540:
65c68
< WARNING: strncpy() is error-prone; please use strlcpy() if possible, or memcpy()#591: FILE: /tmp/f1-22511/csv.c:591:
---
> WARNING: strncpy() is error-prone; please use strlcpy() if possible, or memcpy()#589: FILE: /tmp/f2-22511/csv.c:589:
69c72
< #644: FILE: /tmp/f1-22511/csv.c:644:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11941/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200418-00-g1120b9596-0 (missing) -> 7.4-dev-20200418-00-g1120b9596-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200418-00-g1120b9596-0 (missing) -> 7.4-dev-20200418-00-g1120b9596-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200418-00-g1120b9596-0 (missing) -> 7.4-dev-20200418-00-g1120b9596-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200418-00-g1120b9596-0 (missing) -> 7.4-dev-20200418-00-g1120b9596-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200418-00-g1120b9596-0 (missing) -> 7.4-dev-20200418-00-g1120b9596-0~deb10u1

pimd: don't use strcpy

96e4329

>:( Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

polychaeta added the pim label Apr 18, 2020

lib: don't use strcpy

1120b95

>:( Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

polychaeta added the libfrr label Apr 18, 2020

qlyoung changed the title ~~pimd: don't use strcpy~~ lib,pimd: don't use strcpy Apr 18, 2020

eqvinox merged commit 034cb57 into FRRouting:master Apr 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib,pimd: don't use strcpy #6256

lib,pimd: don't use strcpy #6256

qlyoung commented Apr 18, 2020

LabN-CI commented Apr 18, 2020 •

edited

Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Apr 18, 2020 •

edited

Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Apr 18, 2020 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

Warnings Generated during build:

LabN-CI commented Apr 18, 2020

eqvinox commented Apr 18, 2020

NetDEF-CI commented Apr 18, 2020

lib,pimd: don't use strcpy #6256

lib,pimd: don't use strcpy #6256

Conversation

qlyoung commented Apr 18, 2020

LabN-CI commented Apr 18, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Apr 18, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Apr 18, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

Warnings Generated during build:

LabN-CI commented Apr 18, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

eqvinox commented Apr 18, 2020

NetDEF-CI commented Apr 18, 2020

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Warnings Generated during build:

LabN-CI commented Apr 18, 2020 •

edited

Loading

NetDEF-CI commented Apr 18, 2020 •

edited

Loading

NetDEF-CI commented Apr 18, 2020 •

edited

Loading