ospfd: YANG Model definition for OSPFv2 #6616

mobash-rasool · 2020-06-19T09:22:40Z

Initial version of OSPF configuration Yang.

Raised new PR with review comment fixes on top of PR
#6055

Co-authored-by : Santosh P K sapk@vmware.com
Co-authored-by : Mobashshera Rasool mrasool@vmware.com
Signed-off-by : Mobashshera Rasool mrasool@vmware.com

polychaeta

Thanks for your contribution to FRR!

One of your commits has a missing or badly formatted Signed-off-by line; we can't accept your contribution until all of your commits have one

If you are a new contributor to FRR, please see our contributing guidelines.

blocking comments addressed

LabN-CI · 2020-06-19T09:51:22Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6616 `97ffc57`
Date	06/19/2020
Start	05:25:27
Finish	05:51:14
Run-Time	25:47
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-06-19-05:25:27.txt
Log	autoscript-2020-06-19-05:26:25.log.bz2
Memory	495 500 427

For details, please contact louberger

LabN-CI · 2020-06-19T10:47:46Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6616 `98347f3`
Date	06/19/2020
Start	06:21:44
Finish	06:47:40
Run-Time	25:56
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-06-19-06:21:44.txt
Log	autoscript-2020-06-19-06:22:40.log.bz2
Memory	480 482 425

For details, please contact louberger

odd22

Thanks for this contribution. This is a quick review only on SR, MPLS-TE and Router Information groups where I have some remarks and some requests.

I leave the floor for other reviewers for the remaining parts.

yang/frr-ospfd.yang

mobash-rasool · 2020-06-19T11:14:19Z

NetDEF-CI · 2020-06-19T11:22:24Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12755/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12755/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200619-05-g3561e3881-0 (missing) -> 7.5-dev-20200619-05-g3561e3881-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200619-05-g3561e3881-0 (missing) -> 7.5-dev-20200619-05-g3561e3881-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200619-05-g3561e3881-0 (missing) -> 7.5-dev-20200619-05-g3561e3881-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200619-05-g3561e3881-0 (missing) -> 7.5-dev-20200619-05-g3561e3881-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200619-05-g3561e3881-0 (missing) -> 7.5-dev-20200619-05-g3561e3881-0~deb10u1

NetDEF-CI · 2020-06-19T11:28:46Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12754/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topo tests part 2 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP0U1604AMD64-12754/test

Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 amd64:

ce1: zebra has memory leaks:

  ## showing active allocations in memory group libfrr
    Buffer                        :      4 *         24
    Host config                   :      3 * (variably sized)
    Command Tokens                :   3964 *         72
    Command Token Text            :   2855 * (variably sized)
    Command Token Help            :   2855 * (variably sized)
    Command Argument Name         :   1046 * (variably sized)
    RCU thread                    :      6 *        128
    RCU sequence barrier          :      1 *         32
    FRR POSIX Thread              :     12 * (variably sized)
    POSIX sync primitives         :     12 * (variably sized)
    Graph                         :     25 *          8
    Graph Node                    :   4620 *         32
    Hash                          :    858 * (variably sized)
    Hash Bucket                   :    852 *         32
    Hash Index                    :    429 * (variably sized)
    Interface                     :      2 *        264
    Connected                     :      4 *         48
    Link List                     :     35 *         40
    Link Node                     :    470 *         24
    Temporary memory              :      5 * (variably sized)
    Nexthop                       :      6 *        128
    NetNS Context                 :      2 * (variably sized)
    NetNS Name                    :      1 *         18
    Northbound Node               :    643 *        656
    Northbound Configuration      :      2 *         16
    Northbound Configuration Entry:      2 *        520
    Prefix                        :      4 *         48
    Privilege information         :      4 * (variably sized)
    Stream                        :      8 * (variably sized)
    Stream FIFO                   :      9 *         64
    Route table                   :     13 *         56
    Route node                    :     16 * (variably sized)
    Thread                        :     26 *        168
    Thread master                 :     27 * (variably sized)
    Thread Poll Info              :     14 *     131072
    Thread stats                  :     27 *         72
    Typed-hash bucket             :      9 * (variably sized)
    Vector                        :   9295 *         16
    Vector index                  :   9295 * (variably sized)
    VRF                           :      1 *        200
    VRF bit-map                   :      4 *          8
    Work queue                    :      3 * (variably sized)
    Work queue name string        :      2 * (variably sized)
    YANG module                   :      5 *         48
    log thread-local buffer       :      7 *       9752

  ## showing active allocations in memory group logging subsystem
    log file target               :      1 *         88
    log file name                 :      1 *         78

  ## showing active allocations in memory group Label Manager

  ## showing active allocations in memory group Table Manager

  ## showing active allocations in memory group zebra
    Zebra Interface Information   :      2 *        376
    Zebra DPlane Provider         :      1 *        232
    Route Entry                   :      9 *         80
    RIB destination               :     10 *         88
    Nexthop Group Entry           :      5 *         88
    Nexthop Group Connected       :      4 *         40
    Zebra Name Space              :      5 * (variably sized)
    RIB table info                :      4 *         16
    Nexthop tracking object       :      1 *        232
    ZEBRA VRF                     :      1 *       4744

ce1: sharpd crashed. Core file found - Backtrace follows:
[New LWP 9819]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/sharpd'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007fda65a85428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#0  0x00007fda65a85428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1  0x00007fda65a8702a in __GI_abort () at abort.c:89
#2  0x00007fda662b8410 in ?? () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#3  <signal handler called>
#4  __memcpy_sse2_unaligned () at ../sysdeps/x86_64/multiarch/memcpy-sse2-unaligned.S:37
#5  0x00007fda662e0583 in vbprintfrr () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#6  0x00007fda662e2d2a in vasnprintfrr () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#7  0x00007fda662ddd9c in zlog_msg_text () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#8  0x00007fda662decbf in zlog_fd () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#9  0x00007fda662ddc35 in zlog_tls_buffer_flush () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#10 0x00007fda662ddee8 in ?? () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#11 0x0000557d678ed1e6 in ?? ()
#12 0x0000557d678ed217 in ?? ()
#13 0x00007fda662b86e3 in quagga_sigevent_process () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#14 0x00007fda662c6765 in thread_fetch () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#15 0x00007fda662904eb in frr_run () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#16 0x0000557d678ecf8f in main ()

ce1: bgpd crashed. Core file found - Backtrace follows:
[New LWP 9820]
[New LWP 9826]
[New LWP 9824]
[New LWP 9825]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/bgpd'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007f1efe84f428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
[Current thread is 1 (Thread 0x7f1eff8d1880 (LWP 9820))]
#0  0x00007f1efe84f428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1  0x00007f1efe85102a in __GI_abort () at abort.c:89
#2  0x00007f1eff596410 in ?? () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#3  <signal handler called>
#4  __memcpy_sse2_unaligned () at ../sysdeps/x86_64/multiarch/memcpy-sse2-unaligned.S:37
#5  0x00007f1eff5be583 in vbprintfrr () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#6  0x00007f1eff5c0d2a in vasnprintfrr () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#7  0x00007f1eff5bbd9c in zlog_msg_text () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#8  0x00007f1eff5bccbf in zlog_fd () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#9  0x00007f1eff5bbc35 in zlog_tls_buffer_flush () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#10 0x00007f1eff5bbee8 in ?? () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#11 0x000055cd02609986 in ?? ()
#12 0x000055cd02609aa0 in sigint ()
#13 0x00007f1eff5966e3 in quagga_sigevent_process () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#14 0x00007f1eff5a4765 in thread_fetch () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#15 0x00007f1eff56e4eb in frr_run () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#16 0x000055cd02607611 in main ()

ce1: staticd crashed. Core file found - Backtrace follows:
[New LWP 9811]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/staticd'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007f635d3ad428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#0  0x00007f635d3ad428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1  0x00007f635d3af02a in __GI_abort () at abort.c:89
#2  0x00007f635d9d8410 in ?? () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#3  <signal handler called>
#4  __memcpy_sse2_unaligned () at ../sysdeps/x86_64/multiarch/memcpy-sse2-unaligned.S:37
#5  0x00007f635da00583 in vbprintfrr () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#6  0x00007f635da02d2a in vasnprintfrr () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#7  0x00007f635d9fdd9c in zlog_msg_text () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#8  0x00007f635d9fecbf in zlog_fd () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#9  0x00007f635d9fdc35 in zlog_tls_buffer_flush () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#10 0x00007f635d9fdee8 in ?? () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#11 0x0000560f2b3969f6 in ?? ()
#12 0x0000560f2b396a27 in ?? ()
#13 0x00007f635d9d86e3 in quagga_sigevent_process () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#14 0x00007f635d9e6765 in thread_fetch () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#15 0x00007f635d9b04eb in frr_run () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#16 0x0000560f2b3967a0 in main ()
2020-06-19 12:01:48,071 ERROR: assert failed at "bgp_instance_del_test.test_bgp_instance_del_test/test_memory_leak": 
ce1: zebra has memory leaks:

ce1: sharpd crashed. Core file found - Backtrace follows:
[New LWP 9819]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/sharpd'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007fda65a85428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#0  0x00007fda65a85428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1  0x00007fda65a8702a in __GI_abort () at abort.c:89
#2  0x00007fda662b8410 in ?? () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#3  <signal handler called>
#4  __memcpy_sse2_unaligned () at ../sysdeps/x86_64/multiarch/memcpy-sse2-unaligned.S:37
#5  0x00007fda662e0583 in vbprintfrr () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#6  0x00007fda662e2d2a in vasnprintfrr () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#7  0x00007fda662ddd9c in zlog_msg_text () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#8  0x00007fda662decbf in zlog_fd () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#9  0x00007fda662ddc35 in zlog_tls_buffer_flush () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#10 0x00007fda662ddee8 in ?? () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#11 0x0000557d678ed1e6 in ?? ()
#12 0x0000557d678ed217 in ?? ()
#13 0x00007fda662b86e3 in quagga_sigevent_process () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#14 0x00007fda662c6765 in thread_fetch () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#15 0x00007fda662904eb in frr_run () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#16 0x0000557d678ecf8f in main ()

ce1: bgpd crashed. Core file found - Backtrace follows:
[New LWP 9820]
[New LWP 9826]
[New LWP 9824]
[New LWP 9825]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/bgpd'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007f1efe84f428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
[Current thread is 1 (Thread 0x7f1eff8d1880 (LWP 9820))]
#0  0x00007f1efe84f428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1  0x00007f1efe85102a in __GI_abort () at abort.c:89
#2  0x00007f1eff596410 in ?? () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#3  <signal handler called>
#4  __memcpy_sse2_unaligned () at ../sysdeps/x86_64/multiarch/memcpy-sse2-unaligned.S:37
#5  0x00007f1eff5be583 in vbprintfrr () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#6  0x00007f1eff5c0d2a in vasnprintfrr () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#7  0x00007f1eff5bbd9c in zlog_msg_text () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#8  0x00007f1eff5bccbf in zlog_fd () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#9  0x00007f1eff5bbc35 in zlog_tls_buffer_flush () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#10 0x00007f1eff5bbee8 in ?? () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#11 0x000055cd02609986 in ?? ()
#12 0x000055cd02609aa0 in sigint ()
#13 0x00007f1eff5966e3 in quagga_sigevent_process () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#14 0x00007f1eff5a4765 in thread_fetch () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#15 0x00007f1eff56e4eb in frr_run () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#16 0x000055cd02607611 in main ()

ce1: staticd crashed. Core file found - Backtrace follows:
[New LWP 9811]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/staticd'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007f635d3ad428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#0  0x00007f635d3ad428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1  0x00007f635d3af02a in __GI_abort () at abort.c:89
#2  0x00007f635d9d8410 in ?? () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#3  <signal handler called>
#4  __memcpy_sse2_unaligned () at ../sysdeps/x86_64/multiarch/memcpy-sse2-unaligned.S:37
#5  0x00007f635da00583 in vbprintfrr () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#6  0x00007f635da02d2a in vasnprintfrr () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#7  0x00007f635d9fdd9c in zlog_msg_text () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#8  0x00007f635d9fecbf in zlog_fd () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#9  0x00007f635d9fdc35 in zlog_tls_buffer_flush () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#10 0x00007f635d9fdee8 in ?? () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#11 0x0000560f2b3969f6 in ?? ()
#12 0x0000560f2b396a27 in ?? ()
#13 0x00007f635d9d86e3 in quagga_sigevent_process () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#14 0x00007f635d9e6765 in thread_fetch () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#15 0x00007f635d9b04eb in frr_run () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#16 0x0000560f2b3967a0 in main ()

2020-06-19 12:07:49,047 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP0U1604AMD64/topotests/lib/common_config.py", line 1985, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP0U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP0U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2020-06-19 12:07:49,171 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP0U1604AMD64/topotests/lib/common_config.py", line 1985, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP0U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP0U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2020-06-19 12:07:49,296 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP0U1604AMD64/topotests/lib/common_config.py", line 1985, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP0U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP0U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2020-06-19 12:07:49,422 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP0U1604AMD64/topotests/lib/common_config.py", line 1985, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP0U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP0U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2020-06-19 12:09:51,491 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP0U1604AMD64/topotests/lib/common_config.py", line 1985, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP0U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP0U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12754/artifact/TP0U1604AMD64/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-12754/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-19 12:01:53,263 ERROR: 'router_json_cmp' failed after 6.28 seconds
2020-06-19 12:01:53,264 ERROR: assert failed at "test_bgp-vrf-route-leak-basic/test_vrf_route_leak": BGP VRF DONNA check failed:
  Generated JSON diff error report:
  
  
  > $: d2 has key '10.0.1.0/24' which is not present in d1
  > $: d2 has key '10.0.3.0/24' which is not present in d1
  
  
assert False
2020-06-19 12:05:30,007 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-19 12:05:32,057 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-19 12:05:38,209 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12754/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Ubuntu 16.04 deb pkg check
Topo tests part 1 on Ubuntu 16.04 i386
CentOS 7 rpm pkg check
Topo tests part 2 on Ubuntu 18.04 amd64
Topo tests part 0 on Ubuntu 16.04 i386
Debian 10 deb pkg check
Addresssanitizer topotests part 1
IPv4 ldp protocol on Ubuntu 18.04
Addresssanitizer topotests part 2
Debian 8 deb pkg check
Debian 9 deb pkg check
IPv4 protocols on Ubuntu 18.04
Fedora 29 rpm pkg check
Addresssanitizer topotests part 0
Topo tests part 1 on Ubuntu 16.04 amd64
Static analyzer (clang)
Ubuntu 20.04 deb pkg check
Topo tests part 2 on Ubuntu 16.04 i386
Topo tests part 0 on Ubuntu 18.04 amd64
IPv6 protocols on Ubuntu 18.04
Topo tests part 1 on Ubuntu 18.04 amd64
Ubuntu 18.04 deb pkg check

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12754/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200619-05-g97ffc5707-0 (missing) -> 7.5-dev-20200619-05-g97ffc5707-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200619-05-g97ffc5707-0 (missing) -> 7.5-dev-20200619-05-g97ffc5707-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200619-05-g97ffc5707-0 (missing) -> 7.5-dev-20200619-05-g97ffc5707-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200619-05-g97ffc5707-0 (missing) -> 7.5-dev-20200619-05-g97ffc5707-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200619-05-g97ffc5707-0 (missing) -> 7.5-dev-20200619-05-g97ffc5707-0~deb10u1

NetDEF-CI · 2020-06-19T11:30:49Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12756/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12756/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200619-05-g98347f360-0 (missing) -> 7.5-dev-20200619-05-g98347f360-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200619-05-g98347f360-0 (missing) -> 7.5-dev-20200619-05-g98347f360-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200619-05-g98347f360-0 (missing) -> 7.5-dev-20200619-05-g98347f360-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200619-05-g98347f360-0 (missing) -> 7.5-dev-20200619-05-g98347f360-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200619-05-g98347f360-0 (missing) -> 7.5-dev-20200619-05-g98347f360-0~deb10u1

riw777

Other than the one comment on the PCE stuff, the model and code look fine to me... Leaving open for other folks to review and resolve comments.

LabN-CI · 2020-06-30T11:42:41Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6616 `01cb7a1`
Date	06/30/2020
Start	07:16:31
Finish	07:42:34
Run-Time	26:03
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-06-30-07:16:31.txt
Log	autoscript-2020-06-30-07:17:29.log.bz2
Memory	496 493 430

For details, please contact louberger

NetDEF-CI · 2020-06-30T13:19:09Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12903/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12903/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200630-01-g1b384588d-0 (missing) -> 7.5-dev-20200630-01-g1b384588d-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200630-01-g1b384588d-0 (missing) -> 7.5-dev-20200630-01-g1b384588d-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200630-01-g1b384588d-0 (missing) -> 7.5-dev-20200630-01-g1b384588d-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200630-01-g1b384588d-0 (missing) -> 7.5-dev-20200630-01-g1b384588d-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200630-01-g1b384588d-0 (missing) -> 7.5-dev-20200630-01-g1b384588d-0~deb10u1

NetDEF-CI · 2020-06-30T13:37:06Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12904/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Addresssanitizer topotests part 0: Incomplete

(check logs for details)

Topo tests part 0 un Ubuntu 16.04 arm8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U16ARM8-12904/test

Topology Tests failed for Topo tests part 0 un Ubuntu 16.04 arm8:

*** defaultIntf: warning: r1 has no interfaces
2020-06-30 12:29:16,459 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-30 12:29:18,581 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-30 12:29:24,928 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-30 12:47:25,098 ERROR: 'router_json_cmp' failed after 48.18 seconds
2020-06-30 12:47:30,267 ERROR: assert failed at "test_pbr_topo1/test_pbr_data": "show pbr map" mismatches on r1
assert Generated JSON diff error report:
  
  > $: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "valid": false,
  	    "name": "AKIHABARA",
  	    "policies": [
  	        {
  	            "sequenceNumber": 5,
  	            "installedReason": "Valid",
  	            "installed": true,
  	            "nexthopGroup": {
  	                "installedInternally": 1,
  	                "name": "C",
  	                "installed": true
  	            },
  	            "matchDst": "192.168.4.0/24",
  	            "vrfUnchanged": false
  	        },
  	        {
  	            "nexthopGroup": {
  	                "installedInternally": 1,
  	                "name": "C",
  	                "installed": true
  	            },
  	            "installed": true,
  	            "installedReason": "Invalid Src or Dst",
  	            "sequenceNumber": 10,
  	            "vrfUnchanged": false
  	        },
  	        {
  	            "vrfUnchanged": false,
  	            "installedReason": "No Nexthops",
  	            "sequenceNumber": 15,
  	            "installed": false
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $[0]->policies: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "sequenceNumber": 5,
  		    "installedReason": "Valid",
  		    "installed": true,
  		    "nexthopGroup": {
  		        "installedInternally": 1,
  		        "name": "C",
  		        "installed": true
  		    },
  		    "matchDst": "192.168.4.0/24",
  		    "vrfUnchanged": false
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $[0]->policies[0]->installedReason: d1 has element with value 'Invalid NH-group' but in d2 it has value 'Valid'
  		> $[0]->policies[0]->installed: d1 has element with value 'False' but in d2 it has value 'True'
  		> $[0]->policies[0]->nexthopGroup->installedInternally: d1 has element with value '0' but in d2 it has value '1'
  		> $[0]->policies[0]->nexthopGroup->installed: d1 has element with value 'False' but in d2 it has value 'True'
  	
  	> $[0]->policies: d2 has the following element at index 1 which is not present in d1: 
  	
  		{
  		    "vrfUnchanged": false,
  		    "nexthopGroup": {
  		        "installedInternally": 1,
  		        "name": "C",
  		        "installed": true
  		    },
  		    "installedReason": "Invalid Src or Dst",
  		    "sequenceNumber": 10,
  		    "installed": true
  		}
  	
  		Closest match in d1 is at index 1 with the following errors: 
  	
  		> $[0]->policies[1]->installed: d1 has element with value 'False' but in d2 it has value 'True'
  		> $[0]->policies[1]->installedReason: d1 has element with value 'Invalid NH-group, Invalid Src or Dst' but in d2 it has value 'Invalid Src or Dst'
  		> $[0]->policies[1]->nexthopGroup->installedInternally: d1 has element with value '0' but in d2 it has value '1'
  		> $[0]->policies[1]->nexthopGroup->installed: d1 has element with value 'False' but in d2 it has value 'True'
  	
  
2020-06-30 13:12:52,066 ERROR: 'router_json_cmp' failed after 271.67 seconds

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12904/artifact/TOPO0U16ARM8/ErrorLog/log_topotests.txt

Successful on other platforms/tests

IPv4 ldp protocol on Ubuntu 18.04
Ubuntu 18.04 deb pkg check
Debian 8 deb pkg check
Ubuntu 20.04 deb pkg check
Topo tests part 0 on Ubuntu 16.04 amd64
Topo tests part 1 on Ubuntu 18.04 amd64
Debian 9 deb pkg check
CentOS 7 rpm pkg check
Topo tests part 2 on Ubuntu 18.04 amd64
Topo tests part 2 on Ubuntu 16.04 amd64
Topo tests part 0 on Ubuntu 18.04 amd64
IPv6 protocols on Ubuntu 18.04
Addresssanitizer topotests part 2
Addresssanitizer topotests part 1
Topo tests part 1 on Ubuntu 16.04 amd64
IPv4 protocols on Ubuntu 18.04
Topo tests part 0 on Ubuntu 16.04 i386
Debian 10 deb pkg check
Static analyzer (clang)
Ubuntu 16.04 deb pkg check
Topo tests part 2 on Ubuntu 16.04 i386
Fedora 29 rpm pkg check
Topo tests part 1 on Ubuntu 16.04 i386

mobash-rasool · 2020-07-02T05:52:26Z

All the comments are resolved, request others to review and approve.

LabN-CI · 2020-07-02T06:49:32Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6616 `5804146`
Date	07/02/2020
Start	02:23:29
Finish	02:49:25
Run-Time	25:56
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-07-02-02:23:29.txt
Log	autoscript-2020-07-02-02:24:27.log.bz2
Memory	487 494 427

For details, please contact louberger

NetDEF-CI · 2020-07-02T08:58:34Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12936/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Addresssanitizer topotests part 0: Incomplete

(check logs for details)

Topo tests part 0 un Ubuntu 16.04 arm8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U16ARM8-12936/test

Topology Tests failed for Topo tests part 0 un Ubuntu 16.04 arm8:

*** defaultIntf: warning: r1 has no interfaces
2020-07-02 08:10:35,566 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-07-02 08:10:37,705 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-07-02 08:10:44,054 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-07-02 08:28:38,271 ERROR: 'router_json_cmp' failed after 48.28 seconds
2020-07-02 08:28:43,295 ERROR: assert failed at "test_pbr_topo1/test_pbr_data": "show pbr map" mismatches on r1
assert Generated JSON diff error report:
  
  > $: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "valid": false,
  	    "name": "AKIHABARA",
  	    "policies": [
  	        {
  	            "sequenceNumber": 5,
  	            "installedReason": "Valid",
  	            "installed": true,
  	            "nexthopGroup": {
  	                "installedInternally": 1,
  	                "name": "C",
  	                "installed": true
  	            },
  	            "matchDst": "192.168.4.0/24",
  	            "vrfUnchanged": false
  	        },
  	        {
  	            "nexthopGroup": {
  	                "installedInternally": 1,
  	                "name": "C",
  	                "installed": true
  	            },
  	            "installed": true,
  	            "installedReason": "Invalid Src or Dst",
  	            "sequenceNumber": 10,
  	            "vrfUnchanged": false
  	        },
  	        {
  	            "vrfUnchanged": false,
  	            "installedReason": "No Nexthops",
  	            "sequenceNumber": 15,
  	            "installed": false
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $[0]->policies: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "sequenceNumber": 5,
  		    "installedReason": "Valid",
  		    "installed": true,
  		    "nexthopGroup": {
  		        "installedInternally": 1,
  		        "name": "C",
  		        "installed": true
  		    },
  		    "matchDst": "192.168.4.0/24",
  		    "vrfUnchanged": false
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $[0]->policies[0]->installedReason: d1 has element with value 'Invalid NH-group' but in d2 it has value 'Valid'
  		> $[0]->policies[0]->installed: d1 has element with value 'False' but in d2 it has value 'True'
  		> $[0]->policies[0]->nexthopGroup->installedInternally: d1 has element with value '0' but in d2 it has value '1'
  		> $[0]->policies[0]->nexthopGroup->installed: d1 has element with value 'False' but in d2 it has value 'True'
  	
  	> $[0]->policies: d2 has the following element at index 1 which is not present in d1: 
  	
  		{
  		    "vrfUnchanged": false,
  		    "nexthopGroup": {
  		        "installedInternally": 1,
  		        "name": "C",
  		        "installed": true
  		    },
  		    "installedReason": "Invalid Src or Dst",
  		    "sequenceNumber": 10,
  		    "installed": true
  		}
  	
  		Closest match in d1 is at index 1 with the following errors: 
  	
  		> $[0]->policies[1]->installed: d1 has element with value 'False' but in d2 it has value 'True'
  		> $[0]->policies[1]->installedReason: d1 has element with value 'Invalid NH-group, Invalid Src or Dst' but in d2 it has value 'Invalid Src or Dst'
  		> $[0]->policies[1]->nexthopGroup->installedInternally: d1 has element with value '0' but in d2 it has value '1'
  		> $[0]->policies[1]->nexthopGroup->installed: d1 has element with value 'False' but in d2 it has value 'True'
  	
  
2020-07-02 08:55:30,369 ERROR: 'router_json_cmp' failed after 276.24 seconds

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12936/artifact/TOPO0U16ARM8/ErrorLog/log_topotests.txt

Successful on other platforms/tests

IPv4 protocols on Ubuntu 18.04
Topo tests part 0 on Ubuntu 16.04 i386
Debian 10 deb pkg check
Static analyzer (clang)
Ubuntu 16.04 deb pkg check
Topo tests part 2 on Ubuntu 16.04 i386
Fedora 29 rpm pkg check
Topo tests part 1 on Ubuntu 16.04 i386
IPv4 ldp protocol on Ubuntu 18.04
Ubuntu 18.04 deb pkg check
Debian 8 deb pkg check
Ubuntu 20.04 deb pkg check
Topo tests part 0 on Ubuntu 16.04 amd64
Topo tests part 1 on Ubuntu 18.04 amd64
Debian 9 deb pkg check
CentOS 7 rpm pkg check
Topo tests part 2 on Ubuntu 18.04 amd64
Topo tests part 2 on Ubuntu 16.04 amd64
Topo tests part 0 on Ubuntu 18.04 amd64
IPv6 protocols on Ubuntu 18.04
Addresssanitizer topotests part 2
Addresssanitizer topotests part 1
Topo tests part 1 on Ubuntu 16.04 amd64

odd22

Just a small suggestion to name the list of Segment Routing prefix

yang/frr-ospfd.yang

rwestphal

Looks good to me except for a few minor issues.

Overall the two more important things that need to be changed are:

Add default values whenever they exist, otherwise you'll have lots of additional "destroy()" callbacks to implement later;
Remove the top-level "instance" list since it's unnecessary (more details in my inline comments below).

yang/frr-ospfd.yang

LabN-CI · 2020-07-14T15:26:36Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6616 `1379a1f`
Date	07/14/2020
Start	11:00:30
Finish	11:26:29
Run-Time	25:59
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-07-14-11:00:30.txt
Log	autoscript-2020-07-14-11:01:28.log.bz2
Memory	471 480 428

For details, please contact louberger

LabN-CI · 2020-07-14T15:56:43Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6616 `cbe53d5`
Date	07/14/2020
Start	11:30:28
Finish	11:56:36
Run-Time	26:08
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-07-14-11:30:28.txt
Log	autoscript-2020-07-14-11:31:29.log.bz2
Memory	464 473 425

For details, please contact louberger

NetDEF-CI · 2020-07-14T17:01:05Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13118/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-13118/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-07-14 15:39:24,216 ERROR: 'router_json_cmp' failed after 140.47 seconds
2020-07-14 15:39:24,218 ERROR: assert failed at "test_evpn_pim_topo1/test_converge_protocols": "spine" JSON output mismatches
assert Generated JSON diff error report:
  
  > $->peers->192.168.2.3->connectionsEstablished: d1 has element with value '4' but in d2 it has value '1'
  > $->peers->192.168.2.3->connectionsDropped: d1 has element with value '3' but in d2 it has value '0'

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13118/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topo tests part 1 on Ubuntu 16.04 amd64
Fedora 29 rpm pkg check
IPv6 protocols on Ubuntu 18.04
Addresssanitizer topotests part 1
Topo tests part 1 on Ubuntu 16.04 i386
Debian 8 deb pkg check
Topo tests part 0 on Ubuntu 16.04 amd64
IPv4 protocols on Ubuntu 18.04
Topo tests part 0 un Ubuntu 16.04 arm8
Static analyzer (clang)
Ubuntu 20.04 deb pkg check
Topo tests part 2 on Ubuntu 16.04 i386
Ubuntu 18.04 deb pkg check
Ubuntu 16.04 deb pkg check
Addresssanitizer topotests part 2
Topo tests part 0 on Ubuntu 16.04 i386
Topo tests part 1 on Ubuntu 18.04 amd64
CentOS 7 rpm pkg check
Addresssanitizer topotests part 0
Topo tests part 2 on Ubuntu 18.04 amd64
Debian 10 deb pkg check
Debian 9 deb pkg check
Topo tests part 2 on Ubuntu 16.04 amd64
IPv4 ldp protocol on Ubuntu 18.04

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13118/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200714-00-g1379a1ff2-0 (missing) -> 7.5-dev-20200714-00-g1379a1ff2-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200714-00-g1379a1ff2-0 (missing) -> 7.5-dev-20200714-00-g1379a1ff2-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200714-00-g1379a1ff2-0 (missing) -> 7.5-dev-20200714-00-g1379a1ff2-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200714-00-g1379a1ff2-0 (missing) -> 7.5-dev-20200714-00-g1379a1ff2-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200714-00-g1379a1ff2-0 (missing) -> 7.5-dev-20200714-00-g1379a1ff2-0~deb10u1

NetDEF-CI · 2020-07-14T17:15:34Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13119/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-13119/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64:

rt2: zebra crashed. Core file found - Backtrace follows:
[New LWP 3394]
[New LWP 3395]
[New LWP 3396]
[New LWP 3397]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/zebra --log stdout --log-level debug -d'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007ff41f1f0428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
[Current thread is 1 (Thread 0x7ff41ff6a880 (LWP 3394))]
#0  0x00007ff41f1f0428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1  0x00007ff41f1f202a in __GI_abort () at abort.c:89
#2  0x00007ff41fc2e740 in ?? () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#3  <signal handler called>
#4  0x00007ff41f58d98d in pthread_join (threadid=140686334613248, thread_return=0x0) at pthread_join.c:90
#5  0x00007ff41fbf9b95 in ?? () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#6  0x00007ff41fbfa0bf in frr_pthread_stop () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#7  0x00005605497ab863 in zserv_close_client ()
#8  0x00005605497abbed in ?? ()
#9  0x00007ff41fc3ce30 in thread_call () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#10 0x00007ff41fc068a0 in frr_run () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#11 0x000056054973b192 in main ()
2020-07-14 17:31:42,229 ERROR: assert failed at "test_bfd_isis_topo1/test_memory_leak": 
rt2: zebra crashed. Core file found - Backtrace follows:
[New LWP 3394]
[New LWP 3395]
[New LWP 3396]
[New LWP 3397]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/zebra --log stdout --log-level debug -d'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007ff41f1f0428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
[Current thread is 1 (Thread 0x7ff41ff6a880 (LWP 3394))]
#0  0x00007ff41f1f0428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1  0x00007ff41f1f202a in __GI_abort () at abort.c:89
#2  0x00007ff41fc2e740 in ?? () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#3  <signal handler called>
#4  0x00007ff41f58d98d in pthread_join (threadid=140686334613248, thread_return=0x0) at pthread_join.c:90
#5  0x00007ff41fbf9b95 in ?? () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#6  0x00007ff41fbfa0bf in frr_pthread_stop () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#7  0x00005605497ab863 in zserv_close_client ()
#8  0x00005605497abbed in ?? ()
#9  0x00007ff41fc3ce30 in thread_call () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#10 0x00007ff41fc068a0 in frr_run () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#11 0x000056054973b192 in main ()

*** defaultIntf: warning: r1 has no interfaces

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13119/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topo tests part 1 on Ubuntu 16.04 amd64
Fedora 29 rpm pkg check
Addresssanitizer topotests part 1
IPv6 protocols on Ubuntu 18.04
Topo tests part 1 on Ubuntu 16.04 i386
Debian 8 deb pkg check
IPv4 protocols on Ubuntu 18.04
Topo tests part 0 un Ubuntu 16.04 arm8
Static analyzer (clang)
Topo tests part 0 on Ubuntu 18.04 amd64
Topo tests part 2 on Ubuntu 16.04 i386
Ubuntu 18.04 deb pkg check
Ubuntu 20.04 deb pkg check
Ubuntu 16.04 deb pkg check
Topo tests part 0 on Ubuntu 16.04 i386
Topo tests part 1 on Ubuntu 18.04 amd64
Addresssanitizer topotests part 2
Addresssanitizer topotests part 0
Topo tests part 2 on Ubuntu 18.04 amd64
IPv4 ldp protocol on Ubuntu 18.04
Debian 10 deb pkg check
CentOS 7 rpm pkg check
Debian 9 deb pkg check
Topo tests part 2 on Ubuntu 16.04 amd64

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13119/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200714-00-g504bfa4ce-0 (missing) -> 7.5-dev-20200714-00-g504bfa4ce-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200714-00-g504bfa4ce-0 (missing) -> 7.5-dev-20200714-00-g504bfa4ce-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200714-00-g504bfa4ce-0 (missing) -> 7.5-dev-20200714-00-g504bfa4ce-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200714-00-g504bfa4ce-0 (missing) -> 7.5-dev-20200714-00-g504bfa4ce-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200714-00-g504bfa4ce-0 (missing) -> 7.5-dev-20200714-00-g504bfa4ce-0~deb10u1

NetDEF-CI · 2020-07-14T17:33:30Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13120/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13120/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200714-00-gcbe53d5dd-0 (missing) -> 7.5-dev-20200714-00-gcbe53d5dd-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200714-00-gcbe53d5dd-0 (missing) -> 7.5-dev-20200714-00-gcbe53d5dd-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200714-00-gcbe53d5dd-0 (missing) -> 7.5-dev-20200714-00-gcbe53d5dd-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200714-00-gcbe53d5dd-0 (missing) -> 7.5-dev-20200714-00-gcbe53d5dd-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200714-00-gcbe53d5dd-0 (missing) -> 7.5-dev-20200714-00-gcbe53d5dd-0~deb10u1

yang/frr-ospfd.yang

LabN-CI · 2020-07-21T18:01:13Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6616 `9ceb441`
Date	07/21/2020
Start	13:35:28
Finish	14:01:08
Run-Time	25:40
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-07-21-13:35:28.txt
Log	autoscript-2020-07-21-13:36:26.log.bz2
Memory	488 489 428

For details, please contact louberger

NetDEF-CI · 2020-07-22T01:18:31Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13259/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13259/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200721-08-g9ceb44169-0 (missing) -> 7.5-dev-20200721-08-g9ceb44169-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200721-08-g9ceb44169-0 (missing) -> 7.5-dev-20200721-08-g9ceb44169-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200721-08-g9ceb44169-0 (missing) -> 7.5-dev-20200721-08-g9ceb44169-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200721-08-g9ceb44169-0 (missing) -> 7.5-dev-20200721-08-g9ceb44169-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200721-08-g9ceb44169-0 (missing) -> 7.5-dev-20200721-08-g9ceb44169-0~deb10u1

LabN-CI · 2020-07-22T08:31:29Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6616 `67c6662`
Date	07/22/2020
Start	04:05:27
Finish	04:31:24
Run-Time	25:57
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-07-22-04:05:27.txt
Log	autoscript-2020-07-22-04:06:30.log.bz2
Memory	455 492 425

For details, please contact louberger

NetDEF-CI · 2020-07-22T10:07:26Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13270/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13270/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200722-00-g67c666218-0 (missing) -> 7.5-dev-20200722-00-g67c666218-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200722-00-g67c666218-0 (missing) -> 7.5-dev-20200722-00-g67c666218-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200722-00-g67c666218-0 (missing) -> 7.5-dev-20200722-00-g67c666218-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200722-00-g67c666218-0 (missing) -> 7.5-dev-20200722-00-g67c666218-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200722-00-g67c666218-0 (missing) -> 7.5-dev-20200722-00-g67c666218-0~deb10u1

LabN-CI · 2020-08-06T14:37:40Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6616 `2449adf`
Date	08/06/2020
Start	10:11:37
Finish	10:37:34
Run-Time	25:57
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-08-06-10:11:37.txt
Log	autoscript-2020-08-06-10:12:35.log.bz2
Memory	493 491 425

For details, please contact louberger

NetDEF-CI · 2020-08-06T14:49:06Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13501/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topo tests part 0 on Ubuntu 16.04 amd64: No useful log found

Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topo tests part 0 on Ubuntu 16.04 amd64: No useful log found

Topo tests part 0 on Ubuntu 18.04 amd64: Incomplete

(check logs for details)

Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topo tests part 0 on Ubuntu 16.04 amd64: No useful log found

Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topo tests part 0 on Ubuntu 16.04 amd64: No useful log found

Topo tests part 0 on Ubuntu 18.04 amd64: Incomplete

(check logs for details)

Addresssanitizer topotests part 2: Incomplete

(check logs for details)

Addresssanitizer topotests part 0: Failed (click for details)

Addresssanitizer topotests part 0: No useful log found

Successful on other platforms/tests

Topo tests part 1 on Ubuntu 18.04 arm8
Topo tests part 1 on Ubuntu 16.04 amd64
Fedora 29 rpm pkg check
Addresssanitizer topotests part 1
IPv6 protocols on Ubuntu 18.04
Topo tests part 1 on Ubuntu 16.04 i386
Debian 8 deb pkg check
IPv4 protocols on Ubuntu 18.04
Static analyzer (clang)
Topo tests part 2 on Ubuntu 18.04 arm8
Topo tests part 0 on Ubuntu 18.04 arm8
Topo tests part 2 on Ubuntu 16.04 i386
Ubuntu 18.04 deb pkg check
Ubuntu 20.04 deb pkg check
Ubuntu 16.04 deb pkg check
Topo tests part 1 on Ubuntu 18.04 amd64
Topo tests part 2 on Ubuntu 16.04 amd64
Debian 10 deb pkg check
CentOS 7 rpm pkg check
Topo tests part 2 on Ubuntu 18.04 amd64
Topo tests part 0 on Ubuntu 16.04 i386
IPv4 ldp protocol on Ubuntu 18.04
Debian 9 deb pkg check

Initial version of OSPF configuration Yang. Raised new PR with review comment fixes on top of PR FRRouting#6055 Revision History: 1. Fixed review comments. 2. Removed ospf list with id as key, name can be used as key 3. Corrected the alignment Co-authored-by : Santosh P K <sapk@vmware.com> Co-authored-by : Mobashshera Rasool <mrasool@vmware.com> Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>

LabN-CI · 2020-08-06T16:01:42Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/6616 `3152fdf`
Date	08/06/2020
Start	11:35:29
Finish	12:01:37
Run-Time	26:08
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-08-06-11:35:29.txt
Log	autoscript-2020-08-06-11:36:38.log.bz2
Memory	500 490 427

For details, please contact louberger

NetDEF-CI · 2020-08-06T16:39:08Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13501/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13501/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200806-01-g2449adfda-0 (missing) -> 7.5-dev-20200806-01-g2449adfda-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200806-01-g2449adfda-0 (missing) -> 7.5-dev-20200806-01-g2449adfda-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200806-01-g2449adfda-0 (missing) -> 7.5-dev-20200806-01-g2449adfda-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200806-01-g2449adfda-0 (missing) -> 7.5-dev-20200806-01-g2449adfda-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200806-01-g2449adfda-0 (missing) -> 7.5-dev-20200806-01-g2449adfda-0~deb10u1

NetDEF-CI · 2020-08-06T17:20:52Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13504/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13504/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200806-01-g3152fdfd9-0 (missing) -> 7.5-dev-20200806-01-g3152fdfd9-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200806-01-g3152fdfd9-0 (missing) -> 7.5-dev-20200806-01-g3152fdfd9-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200806-01-g3152fdfd9-0 (missing) -> 7.5-dev-20200806-01-g3152fdfd9-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200806-01-g3152fdfd9-0 (missing) -> 7.5-dev-20200806-01-g3152fdfd9-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200806-01-g3152fdfd9-0 (missing) -> 7.5-dev-20200806-01-g3152fdfd9-0~deb10u1

rwestphal

Thanks for the updates @mobash-rasool! Merging...

polychaeta added the ospf label Jun 19, 2020

polychaeta previously requested changes Jun 19, 2020

View reviewed changes

mobash-rasool force-pushed the yang-fix branch from 97ffc57 to 3561e38 Compare June 19, 2020 09:26

mobash-rasool force-pushed the yang-fix branch from 3561e38 to 98347f3 Compare June 19, 2020 09:27

Spantik mentioned this pull request Jun 19, 2020

OSPFD yang #6055

Closed

odd22 requested changes Jun 19, 2020

View reviewed changes

yang/frr-ospfd.yang Outdated Show resolved Hide resolved

yang/frr-ospfd.yang Outdated Show resolved Hide resolved

yang/frr-ospfd.yang Outdated Show resolved Hide resolved

Spantik requested a review from chiragshah6 June 19, 2020 16:23

riw777 approved these changes Jun 23, 2020

View reviewed changes

mobash-rasool force-pushed the yang-fix branch from 98347f3 to 1b38458 Compare June 30, 2020 11:01

polychaeta added the bgp label Jun 30, 2020

mobash-rasool force-pushed the yang-fix branch from 1b38458 to 01cb7a1 Compare June 30, 2020 11:05

mobash-rasool force-pushed the yang-fix branch from 01cb7a1 to 5804146 Compare July 2, 2020 05:50

odd22 reviewed Jul 7, 2020

View reviewed changes

yang/frr-ospfd.yang Outdated Show resolved Hide resolved

rwestphal requested changes Jul 8, 2020

View reviewed changes

Spantik requested a review from odd22 July 10, 2020 13:38

mobash-rasool force-pushed the yang-fix branch 2 times, most recently from 1379a1f to 504bfa4 Compare July 14, 2020 15:00

mobash-rasool force-pushed the yang-fix branch from 504bfa4 to cbe53d5 Compare July 14, 2020 15:13

odd22 requested changes Jul 15, 2020

View reviewed changes

yang/frr-ospfd.yang Show resolved Hide resolved

yang/frr-ospfd.yang Show resolved Hide resolved

yang/frr-ospfd.yang Show resolved Hide resolved

mobash-rasool force-pushed the yang-fix branch from cbe53d5 to 9ceb441 Compare July 21, 2020 16:56

mobash-rasool force-pushed the yang-fix branch from 9ceb441 to 67c6662 Compare July 22, 2020 08:00

odd22 approved these changes Jul 22, 2020

View reviewed changes

mobash-rasool force-pushed the yang-fix branch from 67c6662 to 2449adf Compare August 6, 2020 13:26

mobash-rasool force-pushed the yang-fix branch from 2449adf to 3152fdf Compare August 6, 2020 15:12

rwestphal approved these changes Aug 6, 2020

View reviewed changes

rwestphal merged commit 904807a into FRRouting:master Aug 6, 2020

ospfd: YANG Model definition for OSPFv2 #6616

ospfd: YANG Model definition for OSPFv2 #6616

Conversation

mobash-rasool commented Jun 19, 2020 • edited Loading

polychaeta left a comment

Choose a reason for hiding this comment

LabN-CI commented Jun 19, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented Jun 19, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

odd22 left a comment

Choose a reason for hiding this comment

mobash-rasool commented Jun 19, 2020

NetDEF-CI commented Jun 19, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Jun 19, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Jun 19, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

riw777 left a comment

Choose a reason for hiding this comment

LabN-CI commented Jun 30, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Jun 30, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Jun 30, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

mobash-rasool commented Jul 2, 2020

LabN-CI commented Jul 2, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Jul 2, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

odd22 left a comment

Choose a reason for hiding this comment

rwestphal left a comment

Choose a reason for hiding this comment

LabN-CI commented Jul 14, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented Jul 14, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Jul 14, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Jul 14, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Jul 14, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

LabN-CI commented Jul 21, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Jul 22, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

LabN-CI commented Jul 22, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Jul 22, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

LabN-CI commented Aug 6, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

mobash-rasool commented Jun 19, 2020 •

edited

Loading

LabN-CI commented Jun 19, 2020 •

edited

Loading

LabN-CI commented Jun 19, 2020 •

edited

Loading

NetDEF-CI commented Jun 19, 2020 •

edited

Loading

NetDEF-CI commented Jun 19, 2020 •

edited

Loading

NetDEF-CI commented Jun 19, 2020 •

edited

Loading

LabN-CI commented Jun 30, 2020 •

edited

Loading

NetDEF-CI commented Jun 30, 2020 •

edited

Loading

NetDEF-CI commented Jun 30, 2020 •

edited

Loading

LabN-CI commented Jul 2, 2020 •

edited

Loading

NetDEF-CI commented Jul 2, 2020 •

edited

Loading

LabN-CI commented Jul 14, 2020 •

edited

Loading

LabN-CI commented Jul 14, 2020 •

edited

Loading

NetDEF-CI commented Jul 14, 2020 •

edited

Loading

NetDEF-CI commented Jul 14, 2020 •

edited

Loading

NetDEF-CI commented Jul 14, 2020 •

edited

Loading

LabN-CI commented Jul 21, 2020 •

edited

Loading

NetDEF-CI commented Jul 22, 2020 •

edited

Loading

LabN-CI commented Jul 22, 2020 •

edited

Loading

NetDEF-CI commented Jul 22, 2020 •

edited

Loading

LabN-CI commented Aug 6, 2020 •

edited

Loading

NetDEF-CI commented Aug 6, 2020 •

edited

Loading

NetDEF-CI commented Aug 6, 2020 •

edited

Loading