Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old Checks support #85

Merged

Conversation

RodrigoMNardi
Copy link
Collaborator

In this PR we will deal with the old GitHub Checks. When a PR runs and has the old entries, it will be marked as skipped and create the 3 new stages. It also fixed a strange behavior when the build stage fails and leaves the testing stage in a peculiar state

In this PR we will deal with the old GitHub Checks.
When a PR runs and has the old entries, it will be marked as skipped and create the 3 new stages.
It also fixed a strange behavior when the build stage fails and leaves the testing stage in a peculiar state

Signed-off-by: Rodrigo Nardi <rnardi@netdef.org>
Code lint

Signed-off-by: Rodrigo Nardi <rnardi@netdef.org>
Fixing class name

Signed-off-by: Rodrigo Nardi <rnardi@netdef.org>
Fixing class name

Signed-off-by: Rodrigo Nardi <rnardi@netdef.org>
@RodrigoMNardi RodrigoMNardi requested a review from mwinter-osr July 3, 2024 17:54
It is correcting a small behavior of the GitHub API that does not return all checks and sometimes does not return the queued status in the first request.

Signed-off-by: Rodrigo Nardi <rnardi@netdef.org>
@RodrigoMNardi RodrigoMNardi merged commit 776d3b8 into FRRouting:master Jul 10, 2024
2 checks passed
@RodrigoMNardi RodrigoMNardi deleted the feature/github/skip_old_tests branch August 14, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant