Skip to content

Commit

Permalink
fix: e2e tests
Browse files Browse the repository at this point in the history
Signed-off-by: Martin Chodur <m.chodur@seznam.cz>
  • Loading branch information
FUSAKLA committed Oct 31, 2024
1 parent 2fdce40 commit 1030bcd
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions examples/human_readable.html
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ <h2><a href="#check-formatting">check-formatting</a></h2>
<ul>
<li>All rules expression is well formatted as would <code>promtool promql format</code> do or similar online tool such as https://o11y.tools/promqlparser/</li>
<li>All rules expression does not do any binary operations between histogram buckets, it can be dangerous because of inconsistency in the data if sent over remote write for example</li>
<li>All rules fails if any rule uses an emoji in metric name or labels</li>
</ul>

<h2><a href="#check-recording-rules">check-recording-rules</a></h2>
Expand Down
1 change: 1 addition & 0 deletions examples/human_readable.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ Validation rules:
check-formatting
- All rules expression is well formatted as would `promtool promql format` do or similar online tool such as https://o11y.tools/promqlparser/
- All rules expression does not do any binary operations between histogram buckets, it can be dangerous because of inconsistency in the data if sent over remote write for example
- All rules fails if any rule uses an emoji in metric name or labels

check-recording-rules
- Recording rule Recorded metric name does not match regexp: ^foo_bar$
Expand Down
4 changes: 2 additions & 2 deletions examples/rules/rules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@ groups:
title: test alert
playbook: http://foo.bar/nonexisting/playbook

# ignore_validations: hasLabels,expressionUsesExistingLabels,hasLabels,hasAnyOfAnnotations,hasAnnotations
# ignore_validations: hasLabels,expressionUsesExistingLabels,hasLabels,hasAnyOfAnnotations,hasAnnotations,expressionCanBeEvaluated,expressionIsWellFormatted
- name: testUTF8
limit: 10
rules:
- alert: test
expr: sum by ("foo.bar") (up)
expr: sum by ("foo.bar") ({"up"})

0 comments on commit 1030bcd

Please sign in to comment.