Merge pull request #544 from FWDekker/detect-closed-issues

Detect duplicates among closed issues too
FWDekker · Oct 13, 2024 · 86fc14a · 86fc14a
2 parents 68e251c + a1cf531
commit 86fc14a
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,9 @@
 # Changelog
+## 9.9.9-unreleased
+### Fixed
+* Fixed bug reported to also check closed issues when checking for duplicates.
+
+
 ## 3.3.2 -- 2024-09-28
 ### Added
 * Added even more debug info for future reports relating to issue [#R1](https://github.com/FWDekkerBot/intellij-randomness-issues/issues/1).

diff --git a/gradle.properties b/gradle.properties
@@ -1,6 +1,6 @@
 group=com.fwdekker
 # Version number should also be updated in `com.fwdekker.randomness.PersistentSettings.Companion.CURRENT_VERSION`.
-version=3.3.2
+version=3.3.3-dev
 
 # Compatibility
 # * `pluginSinceBuild`:

diff --git a/src/main/kotlin/com/fwdekker/randomness/ErrorReporter.kt b/src/main/kotlin/com/fwdekker/randomness/ErrorReporter.kt
@@ -150,7 +150,9 @@ private class GitHubReporter {
     fun report(issueData: IssueData): SubmittedReportInfo =
         try {
             synchronized(this) {
-                val duplicate = issueService.pageIssues(repo).flatSequence().firstOrNull { issueData.isDuplicateOf(it) }
+                val duplicate = issueService.pageIssues(repo, mapOf("state" to "all"))
+                    .flatSequence()
+                    .firstOrNull { issueData.isDuplicateOf(it) }
 
                 val context: Issue
                 if (duplicate == null) {
@@ -365,7 +367,6 @@ private class IssueData(
                     - Randomness version: ${pluginDescriptor.version ?: "_Unknown_"}
                     - IDE version: ${ApplicationInfo.getInstance().apiVersion}
                     - Operating system: ${SystemInfo.OS_NAME}
-                    - Java version: ${SystemInfo.JAVA_VERSION}
                     """.trimIndent()
             )
             .joinToString(separator = "\n\n") { section(it.first, it.second) }
@@ -385,8 +386,8 @@ private class IssueData(
     /**
      * Returns `true` if and only if this [IssueData] is (likely) a duplicate of the existing [Issue].
      */
-    fun isDuplicateOf(issue: Issue): Boolean =
-        issue.title.takeWhile { it != ']' } == title.takeWhile { it != ']' }
+    fun isDuplicateOf(other: Issue): Boolean =
+        this.title.takeWhile { it != ']' } == other.title.takeWhile { it != ']' }
 
 
     /**