Reset fov on crossbow holster #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this sdk we restore player's fov after the save-restore
hlsdk-portable/dlls/player.cpp
Line 2927 in 04e5644
This leads to another bug when switching to weapon after save-restore doesn't reset zoom effect.
To reproduce:
To fix this I use the same condition in
Holsteras the one that is already used inReload, i.e. checking the fov instead ofm_fInZoom(which is not get saved).However, I can imagine other situations when fov doesn't reset. E.g. if player was stripped of weapons while in zoom. These need to be tested.