Skip to content

Commit

Permalink
Fix autoescaping for Twig 2.x
Browse files Browse the repository at this point in the history
Twig 1 and 2 both have an autoescape constructor parameter. In 1.x
passing false was the same as passing 'html'. In 2.x you must explicitly
pass 'html'.

See
- https://github.com/twigphp/Twig/blob/0887422319889e442458e48e2f3d9add1a172ad5/src/Environment.php#L111
- https://github.com/twigphp/Twig/blob/872646a70ff83b3628d50c9bafa117af9f1da59e/src/Environment.php#L92

Closes knapsack-cloud#102.
  • Loading branch information
andriokha committed Feb 20, 2023
1 parent 4b09a3f commit 8581206
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/TwigRenderer.php
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ function __construct(array $config) {
private function createTwigEnv($loaders) {
$twig = new \Twig_Environment($loaders, [
'debug' => $this->config['debug'],
'autoescape' => $this->config['autoescape'],
'autoescape' => $this->config['autoescape'] ? 'html' : false,
'cache' => false, // @todo Implement Twig caching
]);

Expand Down

0 comments on commit 8581206

Please sign in to comment.