Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded limit of 4 bone weight influences #135

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

hypermodule
Copy link
Contributor

This PR aims to remove the hardcoded limit of 4 bone weight influences.

I have tested it manually on a few skeletal meshes from a game that use 8 bone weight influences, and it seems to work.

However, I couldn't try out the glTF export, since it seems to be broken on the current master branch (throws a NullReferenceException when exporting)?

@h4lfheart
Copy link
Collaborator

looks fire!! i don't think this would work properly with psk though bc the importers are hardcoded to 4 weights afaik so that may need to be looked at before merging

@hypermodule
Copy link
Contributor Author

looks fire!! i don't think this would work properly with psk though bc the importers are hardcoded to 4 weights afaik so that may need to be looked at before merging

Thank you, half! ❤️ I have tested the change with both io_scene_psk_psa (DarklightGames) and BlenderPSKPSA (Zain), and both of those Blender addons seem to handle the additional influences without issue. 😊

I think the only obstacle to merging this change is that the 4 weight limit is also hardcoded into FModel's animation snooper code. 😿

@h4lfheart
Copy link
Collaborator

snooper is probs an easy fix, I'm not too familiar but I don't think it should be terribly hard

also a lot of people probably still use the old psk importer so maybe give that a go too? (https://github.com/Befzz/blender3d_import_psk_psa)

@h4lfheart
Copy link
Collaborator

confirmed works with befzz importer and fixes issues with weights on fortnite skins, will merge

@h4lfheart h4lfheart merged commit e15bfa8 into FabianFG:master Apr 28, 2024
@hypermodule hypermodule deleted the more-weight-influences branch July 31, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants