-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for reading/writing single Enigma files #19
Conversation
why not just |
This would break the convention that |
I don't think that convention is important, and I would say it's def worth less than maintaining compatibility |
But it's irritating for the library consumer when there's no coherent naming scheme, I don't want to commit such no-gos. We're in the |
8f2e51c This was the second breaking change I was talking about, and I think it is needed since the |
Temporarily move to my mapping-io fork until this PR gets merged: FabricMC/mapping-io#19
It's be best to have the suffix on both, makes it least surprising. Other formats don't have multiple sub-types in this form so can be left alone. I think it is better to not split the format implementations by version (put both tiny1+tiny2 in |
Done!
Hmm, I feel like if we're adding suffixes anyway, we should apply them consistently. Leads to more confusion otherwise.
Generally I agree, but the only thing tiny v1 and v2 have in common is their name (and tabs), basically everything else is different 😅 Edit: I've merged them into the same package anyway. |
…(PR #1505) * Add option to export mappings as Tiny v2 file * Comply with JADX's import order conventions * Only use Java 8 features * Only use Java 8 features (2) * Export comments to mappings file * Method args test (doesn't work) * Make method arg mapping exports work now * Use `getTopParentClass()` instead of `getParentClass()` See #1505 (comment) * Remove unneeded method load call * Small code cleanup; initial (broken) support for method vars * Fixes regarding inner classes * Add option to export mappings as Enigma directory * Add option to export mappings as Enigma file/directory Temporarily move to my mapping-io fork until this PR gets merged: FabricMC/mapping-io#19 * Fix method vars' lv-indices * Use correct offset value for method var mappings * Also supply lvt-index for method var mappings * Clarify why we're using local mapping-io fork; comment out Fabric Maven for now * Remove unnecessary `public` modifier * Make an `if` condition less complicated * Move mapping export code into jadx-gui (for now) * Make mapping export async; make export menu only clickable when everything is loaded * Fix export mappings menu field declaration position
ca70c2c
to
73b26ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets merge, but get all the planned breaking changes in before releasing
Currently, mapping-io only supports Enigma directories. This PR adds support for single Enigma mapping files. This should bump the library's major version, since
MappingFormat.ENIGMA
now relates to the file instead of the directory structure, which is now calledMappingFormat.ENIGMA_DIR
- same goes for the respective reader and writer classes.Closes #22.