Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to subclass due to Public Access Control restrictions #2

Closed
rchapmanRP opened this issue Aug 10, 2017 · 4 comments
Closed

Unable to subclass due to Public Access Control restrictions #2

rchapmanRP opened this issue Aug 10, 2017 · 4 comments
Labels

Comments

@rchapmanRP
Copy link

Installed with CococaPods and running Xcode 8.3 / Swift 3.1.

Subclassing ConcurrentOperation in my own project with import Queuer as per the README.

On compile, getting the error:

Cannot inherit from non-open class ConcurrentOperation outside of its defining module.

and

Overriding non-open instance method outside of its defining module.

First error fixed by changing ConcurrentOperation from public to open. Must also change the overrides in the class to open to match Access Controls of Operation.

Second error fixed by making -ConcurrentOperation.execute() open as well.

@FabrizioBrancati
Copy link
Owner

You are right! My fault, I was using this project by importing its files and not as a framework.
Thanks for all the info, I will fix this 👍

FabrizioBrancati added a commit that referenced this issue Aug 15, 2017
@FabrizioBrancati
Copy link
Owner

You can use the master branch until I release a new version 👍

@rchapmanRP
Copy link
Author

Awesome! Re-installed from master and its working.

@FabrizioBrancati
Copy link
Owner

I have just released a new version (1.1.0) that includes this fix, point to that instead of master if you want!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants