Paul snow patch 1 #1132
Merged
Paul snow patch 1 #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fd 1128 code hygiene
v6.15.0 (grant round 2021-4)
PaulBernier
reviewed
Nov 19, 2021
| @@ -9,8 +9,8 @@ import ( | |||
|
|
|||
| "github.com/FactomProject/factomd/common/primitives" | |||
|
|
|||
| llog "github.com/FactomProject/factomd/log" | |||
| gcfg "gopkg.in/gcfg.v1" | |||
| "github.com/FactomProject/factomd/log" //deleted 'llog' from beginning | |||
There was a problem hiding this comment.
did you intentionally commit those changes to this file?
There was a problem hiding this comment.
These files should have been in the release, but I guess they were not. I'm guessing the master branch was edited directly. I'd like them to be included (a young kid shadowed the development team last summer, and worked on cleaning up some lint warnings).
But they are not absolutely necessary.
PaulBernier
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lower parallelism to 2 for circleci in response to errors thrown by circleci:
https://app.circleci.com/pipelines/github/FactomProject/factomd/1028/workflows/caa77b9b-a676-49b2-9753-fc4660768f45/jobs/20904