Fd 1287 factable updates march #993
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
receiver names, small refactors, unit test additions.
refactors.
previous PR. 1) Change to iota, 2) change >=
a duplicate function of existing nextAuth2() already in the testing suite
of nextAuth2() after removing other duplicates
to reference *RCD_1, so that caching can work. b) remove zeroReader1 which is a copy of existing zeroReader already in the library, c) Add new unit test for RCD which checks RCD 3 times. - a corrupted sig - a real sig - another corrupted sig This test passes BEFORE my changes because the caching mechanism doesn't work. After my changes the caching mechanism is proven to work, which causes the test to FAIL because the cached result of the 'good' signature returns 'good' even when a corrupted signature is presented to the RCD.
comment on why they fail, and in the future when we should re enable them
…es_march_TO_FACTOM Fd 1287 factable updates march to factom
PaulSnow
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to go into the next release - no rollup created for that yet