Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SPAttachment Control #39

Draft
wants to merge 16 commits into
base: develop
Choose a base branch
from
Draft

Added SPAttachment Control #39

wants to merge 16 commits into from

Conversation

FaganSC
Copy link
Owner

@FaganSC FaganSC commented Jan 16, 2023

Q A
Bug fix? no
New feature? yes
Related issues? mentioned in #16 and mentioned in #15

What's in this Pull Request?

Add SPAttachment Control for both Files and Pictures

FaganSC and others added 4 commits January 4, 2023 20:46
Added Number Field
Added Currency Field
Added Percentage Field
Added Phone Number Field
Bumps [ajv](https://github.com/ajv-validator/ajv) from 8.11.2 to 8.12.0.
- [Release notes](https://github.com/ajv-validator/ajv/releases)
- [Commits](ajv-validator/ajv@v8.11.2...v8.12.0)

---
updated-dependencies:
- dependency-name: ajv
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@FaganSC FaganSC added the enhancement New feature or request label Jan 16, 2023
@FaganSC FaganSC self-assigned this Jan 16, 2023
/*function _handleOnError(msg: string): void {
props.onError(msg);
}*/
const onButtonClick = () => {

Check warning

Code scanning / ESLint

Require explicit return types on functions and class methods

Missing return type on function.
inputFile.current.click();
};

const onChangeFile = (event: any) => {

Check warning

Code scanning / ESLint

Require explicit return types on functions and class methods

Missing return type on function.
}

const displayAttachedFiles = Files.forEach(file => {
let extension: string = file.Name.split('.').pop();

Check warning

Code scanning / ESLint

require `const` declarations for variables that are never reassigned after declared

'extension' is never reassigned. Use 'const' instead.
FaganSC and others added 12 commits January 16, 2023 17:10
…jv-8.12.0

Bump ajv from 8.11.2 to 8.12.0
Bumps [@fluentui/react](https://github.com/microsoft/fluentui) from 8.104.1 to 8.104.5.
- [Release notes](https://github.com/microsoft/fluentui/releases)
- [Changelog](https://github.com/microsoft/fluentui/blob/master/azure-pipelines.release-fluentui.yml)
- [Commits](https://github.com/microsoft/fluentui/compare/@fluentui/react_v8.104.1...@fluentui/react_v8.104.5)

---
updated-dependencies:
- dependency-name: "@fluentui/react"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@rushstack/eslint-config](https://github.com/microsoft/rushstack/tree/HEAD/eslint/eslint-config) from 2.5.1 to 3.1.1.
- [Release notes](https://github.com/microsoft/rushstack/releases)
- [Changelog](https://github.com/microsoft/rushstack/blob/main/eslint/eslint-config/CHANGELOG.md)
- [Commits](https://github.com/microsoft/rushstack/commits/@rushstack/eslint-config_v3.1.1/eslint/eslint-config)

---
updated-dependencies:
- dependency-name: "@rushstack/eslint-config"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
…ushstack/eslint-config-3.1.1

Bump @rushstack/eslint-config from 2.5.1 to 3.1.1
…luentui/react-8.104.5

Bump @fluentui/react from 8.104.1 to 8.104.5
Bumps [@types/webpack-env](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/webpack-env) from 1.15.3 to 1.18.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/webpack-env)

---
updated-dependencies:
- dependency-name: "@types/webpack-env"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…ypes/webpack-env-1.18.0

Bump @types/webpack-env from 1.15.3 to 1.18.0
@sonarcloud
Copy link

sonarcloud bot commented Jan 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant