v18.4_patches: Backport forward compatibility patches for API deprecations in FairLogger and FairMQ
#1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FairRoot depends on a C++11 compiler. This is fully declared and enforced using CMake native tooling. CheckCXX11Features is not used at all any more. So remove all of its usage in CMakeLists.txt. Also remove it from the templates.
We do not need it any longer. And we do not want to provide it to our users. So remove it completely.
Wraps the `FairMQ::FairMQ` target to support the cleaned namespaced FairMQ API (FairRootGroup/FairMQ#423). Also ships transition headers * "FairMQ.h" and * "FairRunFairMQDevice.h". The latter provides a transition from the `<fairmq/runFairMQDevice.h>` to the `<fairmq/runDevice.h>` header which changed the signature and return value of the `getDevice` function (see FairRootGroup/FairMQ@978191f and FairRootGroup/FairMQ@a7dbead).
Since FairMQ v1.4.0 `FairMQLogger.h` was just a wrapper around `fairlogger/Logger.h` because all logging features have been factored out to FairLogger already. See https://github.com/FairRootGroup/FairMQ/blob/v1.4.0/fairmq/FairMQLogger.h
Deprecated in FairMQ v1.4.41 (FairRootGroup/FairMQ@8e6c50e)
* see FairRootGroup/FairMQ#423 * uses transition header `"FairMQ.h"` from `FairRoot::FairMQ` target * minor cleanup of includes and typos
Uses transition header `"FairRunFairMQDevice.h"` from `FairRoot::FairMQ` target. See FairRootGroup/FairMQ@978191f
Upper case severities are deprecated in FairLogger 1.10. So switch all severities over to lower case.
dennisklein
force-pushed
the
v18.4_patches
branch
from
8bfbfb1
to
a3bffa7
Compare
When willingly overriding a virtual method, it is good practice to mark the method with `override`. Most other places already do so.
Increase the buffers to be large enough for a 32bit integer. And switch to snprintf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.