Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect machine arch #4

Closed
wants to merge 3 commits into from
Closed

Conversation

mliang2
Copy link
Contributor

@mliang2 mliang2 commented Aug 7, 2023

This PR fixes #

Checklist

  • I have signed the CLA
  • I have updated/added any relevant documentation

Description

What's the goal of this PR?

Current version hard codes to amd64 architecture. This MR auto detect the architecture to better support arm64 based systems such as Apple M1/M2 CPUs and Linux on ARM64 chips

What changes did you make?

Modified 2 lines auto detect machine architecture via uname -m

What alternative solution should we consider, if any?

None

@CLAassistant
Copy link

CLAassistant commented Aug 7, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mliang2
❌ Michael Leong


Michael Leong seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mliang2 mliang2 closed this Aug 7, 2023
@mliang2 mliang2 deleted the detect_arch branch August 7, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants