Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to Kubernetes deprecated API list #158

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Link to Kubernetes deprecated API list #158

merged 1 commit into from
Feb 17, 2021

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Feb 17, 2021

Link from https://pluto.docs.fairwinds.com/ to the Deprecated API Migration Guide at https://k8s.io/docs/reference/using-api/deprecation-guide/

@CLAassistant
Copy link

CLAassistant commented Feb 17, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

lucasreed
lucasreed approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@lucasreed lucasreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks!

@codecov
Copy link

codecov bot commented Feb 17, 2021 •
edited
Loading

Codecov Report

Merging #158 (e607e1c) into master (de78226) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #158   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files           7        7           
  Lines         418      418           
=======================================
  Hits          347      347           
  Misses         48       48           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de78226...1327a85. Read the comment docs.

sudermanjr
sudermanjr approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's great!

sudermanjr
sudermanjr requested changes Feb 17, 2021
View reviewed changes
Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed, can you also change this in the top-level README? The docs/readme is actually generated from that one.

@sftim
Copy link
Contributor Author

sftim commented Feb 17, 2021

I can revise this!

@sftim sftim requested a review from sudermanjr February 17, 2021 17:40
sudermanjr
sudermanjr approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sudermanjr sudermanjr merged commit 1ec243f into FairwindsOps:master Feb 17, 2021
@sftim sftim deleted the 20210217_link_to_kubernetes_deprecated_api_list branch February 17, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudermanjr sudermanjr sudermanjr approved these changes

@lucasreed lucasreed lucasreed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sftim @CLAassistant @lucasreed @sudermanjr