Adding helm 3 support and refactoring a bit #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lucasreed
commented
Mar 26, 2020
lucasreed
commented
- put all common use into the api package
- added parseOutput function
- helm 3 support (no tests yet)
- helm 2 is not supported yet and will be a challenge
- put all common use into the api package - added parseOutput function - helm 3 support (no tests yet) - helm 2 is not supported yet and will be a challenge
sudermanjr
reviewed
Mar 26, 2020
sudermanjr
requested changes
Mar 26, 2020
There was a problem hiding this comment.
Nice!
lots of nit-picky stuff from me since that's all I could find :-D
There's some golangci-lint stuff too. We should probably add that to the CI at some point
cmd/root.go:135:6: ineffectual assignment to `err` (ineffassign)
_, err = fmt.Fprintln(w, "KIND\t VERSION\t DEPRECATED\t RESOURCE NAME")
^
cmd/root.go:149:7: ineffectual assignment to `err` (ineffassign)
_, err = fmt.Fprintf(w, "%s\t %s\t %s\t %s\t\n", kind, version, deprecated, fileName)
Co-Authored-By: Andrew Suderman <andrew@sudermanjr.com>
Co-Authored-By: Andrew Suderman <andrew@sudermanjr.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.