Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parsing manifests contained into List objects #263

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Add support for parsing manifests contained into List objects #263

merged 1 commit into from
Feb 16, 2022

Conversation

andreadecorte
Copy link
Contributor

This PR fixes issue #255

Checklist

  • [x ] I have signed the CLA
  • [x ] I have updated/added any relevant documentation

Description

What's the goal of this PR?

Add parsing of manifests inside List objects, by expanding their content.

What changes did you make?

Added additional parsing logic.
This should be transparent to users, so I didn't do any change to the documentation, let me know if you want me to do any update

What alternative solution should we consider, if any?

Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit inline.

This is a really nice and easy, and elegant solution. I really like it. Would it be possible for you to also add to the end to end tests to cover this? There's some in the e2e folder. If you just added one that passed a valid list, and one with an invalid list, that would really cover this feature well.

pkg/api/versions.go Outdated Show resolved Hide resolved
pkg/api/versions_test.go Show resolved Hide resolved
@sudermanjr sudermanjr linked an issue Feb 15, 2022 that may be closed by this pull request
@sudermanjr sudermanjr self-assigned this Feb 15, 2022
@andreadecorte
Copy link
Contributor Author

One nit inline.

This is a really nice and easy, and elegant solution. I really like it. Would it be possible for you to also add to the end to end tests to cover this? There's some in the e2e folder. If you just added one that passed a valid list, and one with an invalid list, that would really cover this feature well.

thanks for the comment, indeed I forgot about e2e tests, I added two of them, one with valid manifest and one with a mixed List which I think it is interesting to cover

Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

I would still like to have @lucasreed review this since it's new functionality. Should be able to get this out tomorrow though.

Copy link
Contributor

@lucasreed lucasreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank so much!

@sudermanjr sudermanjr merged commit 32a6a57 into FairwindsOps:master Feb 16, 2022
@andreadecorte andreadecorte deleted the list branch February 16, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate elements for kind: List
3 participants