fix: properly remove emojis in pretty format with no color #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Igor Beliakov <demtis.register@gmail.com>
|
|
2 tasks
rbren
reviewed
Jul 28, 2022
| @@ -211,7 +212,7 @@ func (res ResultSet) GetPrettyOutput() string { | |||
| } | |||
| } | |||
| if color.NoColor { | |||
| status = status[2:] // remove emoji | |||
| status = strings.Fields(status)[1] // remove emoji | |||
There was a problem hiding this comment.
I wonder if this would be safer as
strings.Join(strings.Fields(status)[1:], " ")
There was a problem hiding this comment.
@rbren Please, feel free to adjust it to whatever serves the project best :)
rbren
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #764
Checklist
Description
What's the goal of this PR?
The goal is to fix emojis removal from pretty outputs in colorless mode. Without the fix, you'd get broken binary symbols, e.g.:
Deployment app deploymentMissingReplicas �� Success Reliability - Multiple replicas are scheduledWhat changes did you make?
I haven't seen any double-worded status fields, so instead of slicing, just extracted a word after a whitespace.
If there's a need to have such double-worded names, we can replace the code with:
or any other implementation. In Go 1.18, to which the project hasn't migrated yet, there's strings.Cut(), which I am a fan of. :)
What alternative solution should we consider, if any?
Not really an alternative, but currently I have to play with
sedto remove those symbols.