Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI tag filters and re-enable docs #852

Merged
merged 3 commits into from
Oct 3, 2022
Merged

Fix CI tag filters and re-enable docs #852

merged 3 commits into from
Oct 3, 2022

Conversation

ivanfetch-wt
Copy link
Contributor

@ivanfetch-wt ivanfetch-wt commented Sep 22, 2022 •
edited
Loading

Checklist

  • I have signed the CLA
  • I have updated/added any relevant documentation

Description

What's the goal of this PR?

  • Add tag-filters to the rest of the job in the CircleCI workflow, so the workflow runs when a tag is pushed.
  • Re-enable docs build/push after goreleaser/CI updates.

What changes did you make?

What alternative solution should we consider, if any?

@fairwinds-insights
Copy link

fairwinds-insights bot commented Sep 22, 2022 •
edited
Loading

Fairwinds Insights CI Report

View the Full Report

✅ No new Action Items detected!

@ivanfetch-wt ivanfetch-wt changed the title Re-enable build/push of documentation Fix CI tag filters and re-enable docs Sep 22, 2022
@ivanfetch-wt ivanfetch-wt merged commit b3d842a into master Oct 3, 2022
@ivanfetch-wt ivanfetch-wt deleted the if/fix-ci branch October 3, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbren rbren rbren approved these changes

@makoscafee makoscafee Awaiting requested review from makoscafee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanfetch-wt @rbren