Fix #908 by generating release name #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #908
Checklist
Description
What's the goal of this PR?
The goal is to fix the helm chart auditing so it works for what I am wanting to do today (also makes it work per the docs).
What changes did you make?
I change the helm template command to have helm generate a release name instead of using the helm chart path as the release name (which is frequently not a valid release name).
What alternative solution should we consider, if any?
You may want to hard-code the release name to something more self-explanatory if it shows up in the output like
polarisReleaseName.Testing
I tested the changes locally, and Polaris audit now works instead of breaking quickly. Note, I also ran
go test.