Revert new default value of Select's isClearable prop
#484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suddenly defaulting isClearable to true broke several Selects in ChMS (and likely elsewhere) since they'd written onChange handlers had never needed to expect null values before.
RobertBolender
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suddenly defaulting
isClearabletotruebroke severalSelects in ChMS (and likely elsewhere), since they'd (naturally) writtenonChangehandlers had never needed to expect null values before. This PR just removes that default value—none of the other changes from #478 should be breaking.See this thread for more background/discussion.