Fix: Reduce visibility (#719)

FakerPHP · Sep 5, 2023 · 0f704c8 · 0f704c8
1 parent bf42220
commit 0f704c8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/roave-bc-check.yaml b/roave-bc-check.yaml
@@ -1,6 +1,7 @@
 parameters:
   ignoreErrors:
     - '#\[BC\] CHANGED: Class Faker\\Core\\Coordinates became final#'
+    - '#\[BC\] CHANGED: Method defaultExtensions\(\) of class Faker\\Container\\ContainerBuilder visibility reduced from public to private#'
     - '#\[BC\] CHANGED: Property Faker\\Factory::\$defaultProviders changed default value#'
     - '#\[BC\] CHANGED: Property Faker\\Provider\\[a-z_A-Z]+\\[a-zA-Z]+::\$[1-9a-zA-Z]+ changed default value#'
     - '#\[BC\] CHANGED: Property Faker\\Provider\\[a-zA-Z]+::\$[1-9a-zA-Z]+ changed default value#'
@@ -37,6 +38,7 @@ parameters:
     - '#\[BC\] REMOVED: Class Faker\\Extension\\ContainerException has been deleted#'
     - '#\[BC\] REMOVED: Class Faker\\Extension\\NotInContainerException has been deleted#'
     - '#\[BC\] REMOVED: Method Faker\\Container\\Container\#getDefinitions\(\) was removed#'
+    - '#\[BC\] REMOVED: Method Faker\\Container\\ContainerBuilder\::defaultExtensions\(\) was removed#'
     - '#\[BC\] REMOVED: Method Faker\\Container\\ContainerInterface\#getDefinitions\(\) was removed#'
     - '#\[BC\] REMOVED: Method Faker\\Core\\DateTime\#getDefaultTimezone\(\) was removed#'
     - '#\[BC\] REMOVED: Method Faker\\Core\\DateTime\#getTimestamp\(\) was removed#'

diff --git a/src/Faker/Container/ContainerBuilder.php b/src/Faker/Container/ContainerBuilder.php
@@ -41,11 +41,7 @@ public function build(): ContainerInterface
         return new Container($this->definitions);
     }
 
-    /**
-     * Get an array with extension that represent the default English
-     * functionality.
-     */
-    public static function defaultExtensions(): array
+    private static function defaultExtensions(): array
     {
         return [
             Extension\BarcodeExtension::class => Core\Barcode::class,