php 8 support #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rm populator (fzaninotto#1995) Bug: fzaninotto#1862 Clear specific entities is deprecated and will not be supported in Doctrine 3.0. (doctrine/orm@9ccb883) Bug introduced: c49cd54 Related issue: https://stackoverflow.com/questions/18215975/doctrine-a-new-entity-was-found-through-the-relationship
feat: change the php version constraint to `>=7.3` to allow php 8 and phpunit 9
…config and readme file
17 tasks
|
For me indeed this looks fine. However we should discuss how to continue future development here and just push this as a 1.10 instead. |
pimjansen
approved these changes
Oct 27, 2020
|
Seems like Github Actions aren't running. |
|
Gonna merge this into a temp branch, then PR that to 1.10 once ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
since the original faker will receive no further changes and no php 8 support (fzaninotto#2063 (comment)) I can offer you the very same changes I did on the original project. Of course I don't know where this Fork under this team is heading, but feel free to use my changes if you like.
There is also the possibility to make these changes sort of "cleaner" and use phpunit
^9.0instead ofsymfony/phpunit-bridge, but this requires a php version constraint of>=7.3.