New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve internet tests #81

Merged

pimjansen merged 1 commit into FakerPHP:main from krsriq:CHORE/improve_internet_tests

Nov 29, 2020

krsriq commented Nov 29, 2020

This PR improves the existing internet tests.

filter_var is used to validate email and mac address (so the relevant regex rules are maintained by the php core team)
phpunit markTestSkipped are removed, because the intl extension is required (-dev) anyways
minor cleanups


          improve internet tests

c52f785

Signed-off-by: Daniel Schmelz <q2CIa2U7>

pimjansen approved these changes

View reviewed changes

pimjansen merged commit 0af1e35 into FakerPHP:main

krsriq deleted the CHORE/improve_internet_tests branch

November 29, 2020 10:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet