Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add internet provider slug tests #85

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Add internet provider slug tests #85

merged 2 commits into from
Nov 30, 2020

Conversation

krsriq
Copy link

@krsriq krsriq commented Nov 29, 2020

This PR adds a couple of tests for slug()

@krsriq
add internet provider slug tests
1e9e4d0 
Signed-off-by: Daniel Schmelz <daniel@schmelz.org>
bram-pkg
bram-pkg requested changes Nov 29, 2020
View reviewed changes
@bram-pkg
Copy link
Member

Thanks for the contribution, I left you some feedback.

@krsriq
fix spacing
665b11d 
Signed-off-by: Daniel Schmelz <daniel@schmelz.org>
bram-pkg
bram-pkg approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@bram-pkg bram-pkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bram-pkg bram-pkg merged commit 9246b6b into FakerPHP:main Nov 30, 2020
@krsriq krsriq deleted the CHORE/add_internet_tests branch December 4, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bram-pkg bram-pkg bram-pkg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krsriq @bram-pkg