Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
This PR removes a lot of duplicated code and refactors all the tests. This replaces the previous PR without style changes (sorry for that) #90.
Summary of changes
Generator
instance for each test insetUp
method1
to make results predictableprotected function getProviders(): iterable
allowing developers to easily specify providers needed in the test$this->assert*
and$this->fail()
to static callsassertNotContains
orassertGreaterThan
assertions instead of asserting that comparison returnsfalse
Review checklist