feat: add tvdb indexer #899
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
|
Any update on this feature? 👀 I think this would help with the issue described here #648 |
Sorry, I've got a lot of work at the moment but I've continued to work on it, I'm trying to use directly the api that sonarr uses, skyhook. |
# Conflicts: # server/routes/tv.ts # src/components/TvDetails/index.tsx
github-actions
bot
removed
the
merge conflict
|
Looks like half of the tests are failing. Could you take a look and try to fix them? And add some for TVDB? |
Hello, indeed, I solved the problem of the existing tests and I added tests for tvdb. |
| data.episodes = data.episodes.map((episode) => { | ||
| if (episode.still_path != null && episode.still_path !== '') { | ||
| episode.still_path = `https://image.tmdb.org/t/p/original/${episode.still_path}`; | ||
| } | ||
| return episode; | ||
| }); |
There was a problem hiding this comment.
Why did you made this change?
For src/components/TvDetails/Season/index.tsx?
There was a problem hiding this comment.
That's right, since episodes can differ between tvdb and tmdb, images from tvdb are used in some cases and those from tmdb in others. I had to move the url creation to the indexer classes.
There was a problem hiding this comment.
Makes sense.
You could write your if condition like this (and you shouldn't use loose equality != or ==).
| data.episodes = data.episodes.map((episode) => { | |
| if (episode.still_path != null && episode.still_path !== '') { | |
| episode.still_path = `https://image.tmdb.org/t/p/original/${episode.still_path}`; | |
| } | |
| return episode; | |
| }); | |
| data.episodes = data.episodes.map((episode) => { | |
| if (episode.still_path) { | |
| episode.still_path = `https://image.tmdb.org/t/p/original/${episode.still_path}`; | |
| } | |
| return episode; | |
| }); |
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
|
This can be tested with the |
|
@TOomaAh next time you should rebase instead of merge. Merging makes the history look messy. It's also in our contributing guide to rebase instead of merging |
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
Description
Screenshot (if UI-related)
To-Dos
pnpm buildpnpm i18n:extractIssues Fixed or Closed