Reimplement dev ModDiscovererMixin in more lightweight way #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes compat with forge_mod_discoverer_skip_known_libraries in CoreTweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoreTweaks has a patch that redirects
knownLibraries.contains()inModDiscoverer#findClasspathModsto a method does a much better job at filtering out libraries. This typically reduces startup time by 1-2 seconds. Only, it's incompatible with the way GasStation's ModDiscovererMixin is implemented.This PR reimplements it in a more compatible (and imo clean) way. Functionally it still does the same thing.