Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust Dependencies 2024-05-29 #226

Merged
merged 15 commits into from
Jun 3, 2024

Conversation

tkmcmaster
Copy link
Contributor

@tkmcmaster tkmcmaster commented May 29, 2024

Summary: Updated Cargo dependencies. Resolved a circular dependency in ahash pulled in by using the feature serde-serialize in wasm-bindgen. Removing the feature and then updating wasm-bindgen then fixes the issue. Also replaced the no longer maintained yaml-rust with the fork yaml-rust2. Held back updating hyper and http due to major breaking changes.

@tkmcmaster tkmcmaster self-assigned this May 29, 2024
@tkmcmaster tkmcmaster changed the title Update dependencies rust 2024-05-29 Update Rust Dependencies 2024-05-29 Jun 3, 2024
@tkmcmaster tkmcmaster requested a review from a team June 3, 2024 19:04
@tkmcmaster tkmcmaster marked this pull request as ready for review June 3, 2024 19:14
@tkmcmaster tkmcmaster marked this pull request as draft June 3, 2024 19:23
@tkmcmaster tkmcmaster marked this pull request as ready for review June 3, 2024 19:23
@summersjc
Copy link
Contributor

Do you have some time to go over some of these changes?

@tkmcmaster tkmcmaster merged commit c716994 into master Jun 3, 2024
18 checks passed
@tkmcmaster tkmcmaster deleted the update-dependencies-rust-2024-05-29 branch June 3, 2024 20:37
tkmcmaster added a commit that referenced this pull request Jun 3, 2024
* Moved deprecated .cargo/config to config.toml

* Ignore clippy warning

* Updated body_reader and channel dependencies

* Updated config-wasm and hdr-histogram dependencies

* Updated additional dependencies

- Held back hyper, http, and yansi due to major changes

* Updated Yansi to latest version

- Converted Paint::disable to Yansi::disable
- Removed Windows specific code. Yansi now will try to enable on Windows and automatically disables if it can't activate.

* Added build test-server to the PR script and workflow

* Fix dependency loop with ahash on itself

- tkaitchuck/aHash#95 (comment)
- rustwasm/wasm-bindgen#3031 (comment)

* Updated yaml-rust to use yaml-rust2 due to deprecation

- chyh1990/yaml-rust#197
- chyh1990/yaml-rust#160 (comment)

* Updated cargo deny to remove deprecated entries

- EmbarkStudios/cargo-deny#611
- https://embarkstudios.github.io/cargo-deny/checks/licenses/cfg.html#the-clarify-field-optional

* Updated cargo lock file

* Updated code for deprecations

- Added tests for create_date_diff, then updated deprecated calls and confirmed tests still passed

* Added clippy ignore large results and errors

* Fixed tests to validate to UTC

- Since the PR flow runs on UTC, updated the local PR script to also run UTC
- Updated the create_date_diff test to validate UTC and print a warning to run UTC if it fails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants