Upgrade boa engine trevorm #230
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tkmcmaster
commented
Jun 12, 2024
•
tkmcmaster
commented
- Updated boa_engine to latest relese
- Updated the code to use the new Script and Source types when calling eval
- Added fix for object conversion
- Fixed the purge inner function to correctly handle objects
- Added additional tests
- Reverted some str -> String changes that were unneeded
- Fixed the issue with for_each not overwriting
- 0.17 changed the code that even with READONLY we can't overwrite via register. Changed it to WRITABLE so we can overwrite the for_each
- Fixed match_fn test that was failing
- Starting in 0.17, to_json() does not return integer keys like match returns on the full match. purge_undefined does return it so we'll use that in our test for the validation until fixed
- Fixed clippy warnings
- Removed from_js to str since JsValue no longer supports as_str() - Added back in some commented out code and added fixes
- Removed temporary intermediate variables - Changed to_std_string().expect() calls to to_std_string_escaped() calls
- Fixed the purge inner function to correctly handle objects - Added additional tests - Reverted some str -> String changes that were unneeded
- 0.17 changed the code that even with READONLY we can't overwrite via register. Changed it to WRITABLE so we can overwrite the for_each
- Starting in 0.17, to_json() does not return integer keys like match returns on the full match. purge_undefined does return it so we'll use that in our test for the validation until fixed
summersjc
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.