-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do we need to fetch the complete git history? #120
Comments
Hi there and welcome to this repository! A maintainer will be with you shortly, but first and foremost I would like to thank you for taking the time to report this issue. Quality is of the highest priority for us, and we would never release anything with known defects. We aim to do our best but unfortunately you are here because you encountered something we didn't expect. Lets see if we can figure out what went wrong and provide a remedy for it. |
Wait for FantasticFiasco/action-update-license-year#120 to get resolved
Hi @chances! I think replacing - uses: actions/checkout@v2 with - uses: actions/checkout@v2
with:
fetch-depth: 0 should fix your problem. Can you try it out and report back? |
@FantasticFiasco Hm, that seems to resolve it. Why is |
Try FantasticFiasco/action-update-license-year#120 resolution suggestion
It seems that You can read more about their reasoning here. |
Other GitHub actions that play with Git don't require this flag on the checkout action, e.g. Can your action not workaround it like these other actions? |
Where we in this action run git operations on the same repository checked out by the preceding I'm quite sure that you could have found that out by comparing the source code in this repo with the source code in their repo. So let me turn the table. If removing |
I'm well aware of the actions' differing behavior. My intention in bringing up the The Your action could, instead of expecting the entire history of the target repo, |
You are correct, the change would be for a better one. One could play around with fetch depth, one could also remove the dependency towards I'll leave the issue open. Let's see if it gets some traction. |
I've come to the conclusion that depending on composability, where we depend on Closing issue. |
Describe the bug
Checking out existing branch fails in my CI workflow.
To Reproduce
My workflow file: https://github.com/chances/descartes-d/actions/runs/477666176/workflow
Failing CI build: https://github.com/chances/descartes-d/pull/2/checks?check_run_id=1681534009
Expected behavior
Your license year task is skipped because the
license/2021
branch already exists with license updates.Screenshots
N/A
Additional context
Failing CI build: https://github.com/chances/descartes-d/pull/2/checks?check_run_id=1681534009
The text was updated successfully, but these errors were encountered: