Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication WIP #224

Conversation

tristanpoland
Copy link
Member

This pull request's primary goal is adding authentication features to the community_link_plugin and cleaning up dependencies in Cargo.toml files. Notable changes include adding authentication structures and logic, modifying the PluginConstruct implementation, and updating the Listner struct to handle authentication events.

Authentication Features:

Dependency Management:

@tristanpoland
Copy link
Member Author

@Caznix @haywoodspartan @WilliamAnimate Thoughts on handling the player authentication in the link middleware like I have done here? I'm thinking it should be a reasonable way to handle that, but we will need to add a DB URL to the link config JSON file if we go this route.

I had it as it's own plugin but I think its best to keep plugin types that we have a hard dependency on (such as link) to a minimum.

@tristanpoland tristanpoland self-assigned this Jan 8, 2025
@tristanpoland
Copy link
Member Author

@Caznix Does this look right to you?

static ref AUTHENTICATED_USERS: Arc<RwLock<HashMap<Sid, AuthState>>> =
Arc::new(RwLock::new(HashMap::new()));

// TODO: Obviously, this is not secure. This is just for testing purposes,

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
@tristanpoland
Copy link
Member Author

This will serve as auth until the horizon_network_api crate is created to replace link plugins.

This Will not be the final auth system and is in no way bullet-proof but merely establishes the beginnings of the API.

@tristanpoland tristanpoland marked this pull request as ready for review January 21, 2025 19:23
@tristanpoland tristanpoland merged commit 7bad1ad into main Jan 21, 2025
3 checks passed
@tristanpoland tristanpoland deleted the 153-authentication-process-to-prove-to-the-server-that-the-client-is-really-the-correct-game-client branch January 22, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication process to prove to the server that the client is really the correct game client
1 participant