Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Find All" list is truncated from the top on a short screen. #769

Closed
MKadaner opened this issue Dec 30, 2023 · 4 comments
Closed

"Find All" list is truncated from the top on a short screen. #769

MKadaner opened this issue Dec 30, 2023 · 4 comments
Labels

Comments

@MKadaner
Copy link
Contributor

Far Manager version

3.0.6240.0

OS version

10.0.22621.2861

Other software

No response

Steps to reproduce

  1. Resize Far console windows to 15 lines tall.
  2. Edit a file with a certain text fragment repeats multiple times.
  3. Search for this repeated pattern and press All button.
  4. Observe the "Find All" is shifted way up the screen and truncated at the top.

Expected behavior

No response

Actual behavior

image

image

image

@MKadaner MKadaner added the bug label Dec 30, 2023
@MKadaner
Copy link
Contributor Author

The issue actually goes back at least as far as 3.0.6000.0. I did not dig deeper into the history.

@alabuzhev
Copy link
Contributor

const auto MenuY1 = ScrY - 20;

Well, 14 - 20 will be outside the screen indeed. At least we don't crash.

As far as I remember, the idea was to move the list down to not obscure the editor and see some context.

@alabuzhev
Copy link
Contributor

6241

@MKadaner
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants