Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: allow installing without git #492

Merged

Conversation

branchvincent
Copy link
Contributor

@branchvincent branchvincent commented Jul 29, 2023

This allows installing from a tarball rather than requiring a git clone, which is helpful for downstream distributors (such as Homebrew).

Before:

$ pip3 install https://github.com/mgbellemare/Arcade-Learning-Environment/archive/refs/tags/v0.8.1.tar.gz
...
× Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [25 lines of output]
      fatal: not a git repository (or any of the parent directories): .git

After:

$ pip3 install https://github.com/branchvincent/Arcade-Learning-Environment/archive/refs/heads/tarball.tar.gz
...
Successfully built ale-py

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit d2c22f5 into Farama-Foundation:master Dec 4, 2023
@branchvincent branchvincent deleted the tarball branch December 4, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants