Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: patch to use system pybind11 #528

Merged

Conversation

chenrui333
Copy link
Contributor

Signed-off-by: Rui Chen <rui@chenrui.dev>
@pseudo-rnd-thoughts
Copy link
Member

Thanks for the PR, I'm a bit confused why the tests are failing.
When building from scratch, the PR passes (CI / windows-latest py 3.8) however, when we build the wheels then install and run tests, this fails, not recognising the compiled part.

@chenrui333 Do you have any idea why this might be?

@chenrui333
Copy link
Contributor Author

I am seeing the same test failure on my homebrew build side too

@chenrui333
Copy link
Contributor Author

@chenrui333
Copy link
Contributor Author

chenrui333 commented May 29, 2024

@pseudo-rnd-thoughts does that answer your concern? (this PR works for the homebrew build, thanks!)

@pseudo-rnd-thoughts
Copy link
Member

Errr, no as the CI is still failing so we can't merge.

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenrui333 The problem was unrelated to the PR, and have fixed the issue. Therefore, merging. Thanks again for the PR

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit f30f113 into Farama-Foundation:master Jul 23, 2024
28 checks passed
@chenrui333
Copy link
Contributor Author

Thanks for the merge!

@chenrui333 chenrui333 deleted the use-system-pybind11 branch July 23, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants