-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: patch to use system pybind11 #528
cmake: patch to use system pybind11 #528
Conversation
Signed-off-by: Rui Chen <rui@chenrui.dev>
Thanks for the PR, I'm a bit confused why the tests are failing. @chenrui333 Do you have any idea why this might be? |
I am seeing the same test failure on my homebrew build side too |
this also failed for me as well, https://github.com/chenrui333/Arcade-Learning-Environment/actions/runs/9179613891/job/25242161636 |
@pseudo-rnd-thoughts does that answer your concern? (this PR works for the homebrew build, thanks!) |
Errr, no as the CI is still failing so we can't merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chenrui333 The problem was unrelated to the PR, and have fixed the issue. Therefore, merging. Thanks again for the PR
f30f113
into
Farama-Foundation:master
Thanks for the merge! |
patch to use system pybind11