Add compatibility with pytest version 8 #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deprecated_handler() function is called by module level __getattr__ functions. It raised an ImportError when a module wasn't an env. This breaks getattr's behaviour when it is called with a default value. It expects __getattr__ to raise an AttributeError if the attr is not found. Pytest was apparently updated to call getattr(obj, key, default) for several values of key. The import error isn't caught by getattr, breaking the test. Changing ImportError to AttributeError fixes this. The missing attribute raises the correct error, which is caught by getattr, which sets the value to the default and everything works as intended.
The new version of pytest-markdon-docs caught several problems that the old version missed. The examples now pass with the new version.
Required to work with version 8 of pytest
This was referenced Feb 7, 2024
elliottower
reviewed
Feb 13, 2024
elliottower
reviewed
Feb 13, 2024
elliottower
reviewed
Feb 14, 2024
elliottower
approved these changes
Feb 14, 2024
To prevent tests randomly failing due to a dependency upgrade
This is the last versino to support python 3.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a problem in deprecation handler that failed with version 8 of pytest
Upgraded to a version of pytest-markdown-docs that is compatible with pytest version 8.
That found several errors in the sample docs that have been fixed.
Type of change
Checklist:
pre-commitchecks withpre-commit run --all-files(seeCONTRIBUTING.mdinstructions to set it up)pytest -vand no errors are present.pytest -vhas generated that are related to my code to the best of my knowledge.