Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gymnasium to 1.0.0a1 and remove Atari in favour of ale-py new gymnasium implementation #117

Merged

Conversation

pseudo-rnd-thoughts
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts commented Mar 7, 2024

Description

With Gymnasium releasing 1.0.0a1, this PR updates Shimmy to work with it, removing atari support in the process as ale-py >= 0.9.0 will support it

@pseudo-rnd-thoughts
Copy link
Member Author

Meltingpot is broken due to Chex update (google-deepmind/meltingpot#221) and they haven't released a new pip install yet.
Therefore, we can either install the git project or wait and hope for a release

@pseudo-rnd-thoughts
Copy link
Member Author

dm-lab is failing due to problems loading a shared object file
meltingpot is failing due to chex limitation and no limitation on jax, waiting for new pip install

@elliottower
Copy link
Contributor

Can’t we just use an older version of Chex and melting pot? Until they update it

@pseudo-rnd-thoughts
Copy link
Member Author

@elliottower DM updated meltingpot so that issue is all fixed
The only issue is Dm-lab, any thoughts on what to do?

@elliottower
Copy link
Contributor

@elliottower DM updated meltingpot so that issue is all fixed The only issue is Dm-lab, any thoughts on what to do?

If I get a chance in the next few days I can fire up my docker instance that has dm lab and test it, otherwise no idea honestly

@pseudo-rnd-thoughts
Copy link
Member Author

If you can run the tests on the your machine locally that would be helpful
At worst, we can merge the PR and cut a release and clarify that dm-lab might be broken.

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 1986692 into Farama-Foundation:main May 21, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants