-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix installation with git via pip #37
Fix installation with git via pip #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this change, doesn't it mean that if it fails, the project will have no __version__
?
Could you try using the os.path.abspath(__file__)
to see if this fixes the path name
@pseudo-rnd-thoughts I'm a little confused, could you emphasize further? The reason I had to wrap this in a try/except is because when the project is installed via |
To my understanding, the file is rather Line 104 in ee019a6
VERSION rather than VERSION.txt but this seems unrelated
|
retro/__init__.py
Outdated
@@ -8,8 +8,14 @@ | |||
ROOT_DIR = os.path.abspath(os.path.dirname(__file__)) | |||
core_path(os.path.join(os.path.dirname(__file__), "cores")) | |||
|
|||
with open(os.path.join(os.path.dirname(__file__), "../VERSION")) as f: | |||
__version__ = f.read() | |||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that we have fixed this bug, could we remove the try except and the extra if statement at the end?
Otherwise, looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pseudo-rnd-thoughts unfortunately the bug is still present. The reason is because there is no VERSION
file included in the install at all. I've included the VERSION
file in MANIFEST.in
and made the setup.py
edit you suggested and still no luck. What is odd is that the Version
field of pip show stable-retro
is populated with the correct value. Any ideas? Please see the screenshot for reference
Trying the colab, I found that none of the package data was included, therefore, I think there is an issue with that. |
I agree, two version files is a bad idea. I can implement that workaround later today |
Issue has been fixed. @pseudo-rnd-thoughts please take another look when you have a free second, thank you! |
Fixes the bug in this issue