Py311 + Py312 support #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you for this! I will test it a bit more first before merging it |
|
I believe I fixed the errors :) . I tested py311 and py312 locally with pytest. |
|
Thanks for rerunning the tests. Looks like there's some issues with pre-commit formatting the files weirdly. |
|
Seems the .github folder of pybind11 was committed as well, is there a need for that? |
|
There isn't. I'll remove it. It's an artifact of using |
MatPoliquin
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haven't tested this PR beyond running
make,make testandpip3 install ., but this PRgit subrepoto the newest version (v2.11.1) to enable Python 3.11 and 3.12 support