Skip to content

Latest commit

 

History

History
28 lines (23 loc) · 1006 Bytes

Proposals could allow `Timelock.admin` takeover.md

File metadata and controls

28 lines (23 loc) · 1006 Bytes

The Governor contract contains special functions to let the guardian queue a transaction to change the Timelock.admin.

However, a regular Proposal is also allowed to contain a transaction to change the Timelock.admin.

This poses an unnecessary risk in that an attacker could create a Proposal to change the Timelock.admin.

Recommendation:

Short term, add a check that prevents setPendingAdmin to be included in a Proposal


Slide Screenshot

036.jpg


Slide Text

  • ToB Audit Origin Dollar Finding 9
  • Access Control
  • High Severity
  • Timelock.admin Change
  • Proposal Transaction
  • Prevent setPendingAdmin

References


Tags