Fix: Issues with cooperative-sticky strategy #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…world" scenarios (e.g., cooperative sticky). * Enabled automatic committing with `confluent auto commit: true` instead of relying solely on manual commits, but only when the consumer strategy is cooperative sticky. (Refer to the open librdkafka issue at confluentinc/librdkafka#4059).
… support for the cooperative sticky strategy, allowing for more thorough testing and analysis.
…world" scenarios (e.g., cooperative sticky). Fixes issue Farfetch#557 and Fixes issue Farfetch#456 * Enabled automatic committing with `confluent auto commit: true` instead of relying solely on manual commits, but only when the consumer strategy is cooperative sticky. (Refer to the open librdkafka issue at confluentinc/librdkafka#4059).
… support for the cooperative sticky strategy, allowing for more thorough testing and analysis.
… into fix/sticky-cooperative-strategy
|
Great work 🚀 with this PR. Can you also add some tests as well to validate this use case? 🙇 |
- Added 3 new test files to improve coverage: - `ConsumerConfigurationBuilderTests.cs` - `KafkaConfigTests.cs` - `PartitionAssignmentStrategyTests.cs` - Fixed a bug in `ClusterConfiguration` related to the `AutoCommitInterval` initialization.
|
We'd love to have this feature. Any updates on the implementation of the tests? |
Unit tests were added 2 months ago. |
|
Great. Any updates on getting the feature reviewed @dosper7? |
|
Great to see it happening! Thanks @golanbz for working on it! |
brmagadutra
approved these changes
Feb 3, 2025
|
@golanbz thanks for the contribution! Can you please rebase the PR with master. |
|
Hooray! Things are moving! I am so excited! :) |
…world" scenarios (e.g., cooperative sticky). * Enabled automatic committing with `confluent auto commit: true` instead of relying solely on manual commits, but only when the consumer strategy is cooperative sticky. (Refer to the open librdkafka issue at confluentinc/librdkafka#4059).
… support for the cooperative sticky strategy, allowing for more thorough testing and analysis.
- Added 3 new test files to improve coverage: - `ConsumerConfigurationBuilderTests.cs` - `KafkaConfigTests.cs` - `PartitionAssignmentStrategyTests.cs` - Fixed a bug in `ClusterConfiguration` related to the `AutoCommitInterval` initialization.
brmagadutra
force-pushed
the
fix/sticky-cooperative-strategy
branch
from
0816113 to
0683df5
Compare
… into fix/sticky-cooperative-strategy
|
@golanbz can you please check the errors on the lint step? Also, rebase with the latest changes from master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cooperative-stickyprotocol #456.confluent.auto.commit: truefor the cooperative sticky consumer strategy, instead of relying solely on manual commits. This change is particularly relevant due to the ongoing issue in librdkafka (see: Consumers should not be able to commit during a rebalance confluentinc/librdkafka#4059).How Has This Been Tested?
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement.