-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor access-front-door #5
Conversation
1c0ae01
to
a3929dd
Compare
cd77f40
to
1ad419f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! I've used it as an opportunity to ask a bunch of questions and try and learn more about python/micropython!
access-front-door/src/main.py
Outdated
if params.get('psk') != env.SHARED_PASSWORD: | ||
return | ||
|
||
duration = self.parse_duration(params.get("duration")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's figure out how we want to pass parameters between nodes -- I think currently I've set it up so there's a special params
parameter which would need additional parsing to extract duraction=X
from the value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't 100% sure how you were doing it before, but to me it made sense to send it in a POST
body. phew
supports both json
and form data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got this running on the chip tonight and it works great! I bumped into a few issues, and that's this fresh wave of comments is from
request
params don't existduration
toint
run.sh
to copy files to the device and runmain.py
from command lineaccess-front-door/README.md
Not tested