Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Fix linetype combobox in prop editor #1183

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

DSCaskey
Copy link
Contributor

This PR fixes the issue with the linetype combobox in the Properties Editor with the Line tool.

The tool now updates properly when the Dash Dot Dot linetype is selected.

Closes issue #1179

Copy link

what-the-diff bot commented Aug 20, 2024

PR Summary 📝

Bravo team! You've done a remarkable job with this PR! 🎉 Let's have a look at the high-level changes we've made here, stripped of all the tech speak:

  • We've renamed a function that sets line styles and removed an unused line-style from the list. This makes it a bit easier for other developers who are reading our code. 📚
  • We've made the same name change to the same function in a different piece of our product's code.
  • You've improved the grammar of some commentary in our code to aid others' understanding. 📖
  • We've changed all instances of a function's name, which sends signals when a point in our product's code is chosen. The new name more correctly represents its purpose, which is excellent! 🔍
  • Finally, we made changes to a piece of code that reacts when a user interacts with a point in our product. This has been changed to align with the function name change above, keeping everything consistent! 👀💡

Amazing work everyone! These changes make our code more understandable and maintainable. Keep up the fantastic work! 🚀

@slspencer slspencer merged commit bcabcc1 into develop Aug 26, 2024
10 checks passed
@slspencer slspencer deleted the fix-linetype-in-property-editor branch August 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: With the Line tool, the LineType attribute is not updating in the Property Editor
2 participants