Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix xml tag order #1214

Merged
merged 1 commit into from
Nov 23, 2024
Merged

bug: fix xml tag order #1214

merged 1 commit into from
Nov 23, 2024

Conversation

DSCaskey
Copy link
Contributor

@DSCaskey DSCaskey commented Nov 18, 2024

This PR fixes the order of the groups and images XML tags. Instead of writing those tags as one of those resources is added, the app will now create the tags when the draftblock basepoint is created - maintaining the proper draftblock
structure.

<draftBlock name="Draft block 1">
    <calculation>
        <point id="1" mx="0.0520833" my="0.104167" name="A" showPointName="true" type="single" x="0.3125" y="0.416667"/>
    </calculation>
    <modeling/>
    <pieces/>
    <groups/>
    <images/>
</draftBlock>

This closes issue #1213

Copy link

what-the-diff bot commented Nov 18, 2024

PR Summary 📝

Awesome work everyone! Our code is going to read like a well-written novel thanks to these changes! 📚

  • Refined Header Comments 🖋️
    You'll find our header comments are now crystal clear and organized. A breath of fresh air for anyone new to the code! 🎊

  • Integrated DOM Handling Feature 🛠️
    Cherish the power of QDomElement as it's now part of our family! This enables us to handle DOM much easier! 😎

  • An All-New Commenting Style 👌
    We've opted for single-line comments over multi-line block comments for constructors and methods. This makes our code easier on the eyes! 💫

  • Renamed Variables and Elements for Clarity 💡
    We've worked hard to ensure everything is named logically and sensibly. One key change being patternPiece is now known as draftblock in the AddToFile method, enhancing our code clarity! 👏

  • Enhanced XML structure 🚀
    Not just renaming, our XML structure in the AddToFile method has also upped its game! New elements, TagGroups and TagDraftImages, have been introduced to the draftblock for better organization. This change will help us navigate the code like professional explorers! 🧭

  • Cranked Up Consistency Across Method Documentation 📃
    We've vowed for consistency! And, made a big step towards it by unifying our vocabulary in the method documentation. It's now an absolute joy to read! ✨

Great job everyone! Keep those fantastic updates coming! 💪😊

@DSCaskey DSCaskey linked an issue Nov 18, 2024 that may be closed by this pull request
@DSCaskey DSCaskey merged commit c0e034c into develop Nov 23, 2024
10 checks passed
@DSCaskey DSCaskey deleted the fix-file-tag-issue branch November 23, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: incorrect order of XML tags
2 participants