change default output path for kiota with endpoint mapping

FastEndpoints · Jan 27, 2024 · 6168d61 · 6168d61
1 parent 305921b
commit 6168d61
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 5 deletions.
diff --git a/Src/ClientGen.Kiota/ClientGenConfig.cs b/Src/ClientGen.Kiota/ClientGenConfig.cs
@@ -11,7 +11,11 @@ public sealed class ClientGenConfig : GenerationConfiguration
     public string SwaggerDocumentName { get; set; } = null!;
 
     /// <summary>
-    /// specify whether to zip up the generated client files
+    /// specify whether to zip up the generated client files.
+    /// <para>
+    /// NOTE: this property has no effect when client generation endpoints are mapped as the creation of a zip archive is mandatory
+    /// in order to provide a downloadable byte stream.
+    /// </para>
     /// </summary>
     public bool CreateZipArchive { get; set; }
 

diff --git a/Src/ClientGen.Kiota/Extensions.cs b/Src/ClientGen.Kiota/Extensions.cs
@@ -29,14 +29,12 @@ public static IEndpointRouteBuilder MapApiClientEndpoint(this IEndpointRouteBuil
             route,
             async (IHost app, HttpContext httpCtx, CancellationToken ct) =>
             {
-                var c = new ClientGenConfig { OutputPath = "ClientGen" };
+                var c = new ClientGenConfig { OutputPath = Path.Combine(Path.GetTempPath(), "KiotaClientGen") };
                 config(c);
                 c.CreateZipArchive = true;
 
                 await GenerateClient(app, c, ct);
 
-                Directory.Delete(c.OutputPath, true);
-
                 var zipFile = Path.GetFullPath(c.ZipOutputFile!);
                 await Results.File(
                                  path: zipFile,

diff --git a/Src/Directory.Build.props b/Src/Directory.Build.props
@@ -1,7 +1,7 @@
 <Project>
     <PropertyGroup>
 
-        <Version>5.21.2.17-beta</Version>
+        <Version>5.21.2.18-beta</Version>
 
         <TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks>
         <LangVersion>latest</LangVersion>

diff --git a/Src/Library/changelog.md b/Src/Library/changelog.md
@@ -94,6 +94,12 @@ Now the Swagger path parameter is correctly rendered to match with the exact val
 
 </details>
 
+<details><summary>Change default output location for Kiota Api Client generation</summary>
+
+When using `.MapApiClientEndpoint()`, previously the default value was a sub folder called `ClientGen` under the current folder. The default has been changed to a sub folder called `KiotaClientGen` in the current user's `TEMP` folder away from any project/source files, which is a much safer default location.
+
+</details>
+
 ## Fixes 🪲
 
 <details><summary>Type discovery source generator creating duplicates for partial classes</summary>