Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TextNode as StringNode; JsonNode.xxxTextYyy() (mostly) as JsonNode.xxxStringYyy() [JSTEP-3] #4879

Closed
cowtowncoder opened this issue Jan 1, 2025 · 0 comments
Labels
3.0 Issue planned for initial 3.0 release

Comments

@cowtowncoder
Copy link
Member

cowtowncoder commented Jan 1, 2025

As per JSTEP-3 (and related to JSTEP-6) we want to unify naming of types and accessors: Jackson 2.x uses "Text" instead of "String" (unlike everything else in Jackson 2.x API), so with 3.0 we can fix the discrepancy.

So we will:

  1. Rename TextNode as StringNode (it is unlikely actual type often referred to in application code)
  2. Rename JsonNode accessor methods to use "String" instead of "Text" in most cases; deprecated+add in others

What this specifically means is that we'll change:

  • asText()/asText(String): deprecate, add asString()/asString(String)
  • findValuesAsText(): rename as findValuesAsString()
  • isTextual(): deprecate, add isString()
  • textValue(): rename as stringValue()
@cowtowncoder cowtowncoder added the 3.0 Issue planned for initial 3.0 release label Jan 1, 2025
cowtowncoder added a commit that referenced this issue Jan 1, 2025
cowtowncoder added a commit that referenced this issue Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0 Issue planned for initial 3.0 release
Projects
None yet
Development

No branches or pull requests

1 participant