doc: Add note about JsonNode.elements() -> values() rename
#4873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JooHyukKim
changed the title
JsonNode.elements() -> values() renameJsonNode.elements() -> values() rename in Jackson 3, IN Jackson 2
JooHyukKim
changed the title
JsonNode.elements() -> values() rename in Jackson 3, IN Jackson 2JsonNode.elements() -> values() rename in Jackson 3, "IN" Jackson 2
JooHyukKim
changed the title
JsonNode.elements() -> values() rename in Jackson 3, "IN" Jackson 2JsonNode.elements() -> values() rename
JooHyukKim
commented
Dec 31, 2024
| @@ -1071,6 +1071,8 @@ public boolean hasNonNull(int index) { | |||
| * this node is a JSON Array or Object node. In case of Object node, | |||
| * field names (keys) are not included, only values. | |||
| * For other types of nodes, returns empty iterator. | |||
| * <p> | |||
| * Note: In Jackson 3, this method will be renamed to {@code values()}. | |||
There was a problem hiding this comment.
Either this.... or do both of below
@Deprecatedelements()- Add new
values()method in 2.19 version
There was a problem hiding this comment.
I'll merge this, would accept PR for (2) too -- let's wait bit longer until doing (1) (like 2.20).
There was a problem hiding this comment.
Actually, one note: I will file another issue for changing return type of values() to Collection<JsonNode>, to align with other accessors (properties(), propertyNames()) -- easier to use than Iterator.
This will mean that elements() vs values() is not a simple rename, although latter will still be replacement for former.
There was a problem hiding this comment.
@JooHyukKim Ok, I decided to revisit #4869, see changed description. So part is done for 2.19, rest for 3.0.
cowtowncoder
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought maybe we could help users to have a clue?
#4870