Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support StreamWriteConstraints limits #602

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

pjfanning
Copy link
Member

@pjfanning pjfanning commented Jul 8, 2023

relates to FasterXML/jackson-core#1055

For deserialization, we rely on Woodstox (or other XML Stream Parser impl) to police the max depth. See https://github.com/FasterXML/jackson-dataformat-xml#usage for how you can configure Woodstox parser (and set the P_MAX_ELEMENT_DEPTH - default 1000).

Woodstox does not appear to support such a feature for XML writing so jackson-dataformat-xml needs it own code.

@pjfanning pjfanning changed the title police against cyclic data police against issues serializing cyclic data Jul 8, 2023
Copy link
Member

@cowtowncoder cowtowncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will change exception to check to DatabindException for easier merging.

@cowtowncoder cowtowncoder merged commit a9c90e3 into FasterXML:2.16 Jul 11, 2023
@cowtowncoder cowtowncoder changed the title police against issues serializing cyclic data Support StreamWriteConstraints limits Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants