Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix for iterable collection builder methods not treating iterable as a collection #648

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

bpasson
Copy link
Contributor

@bpasson bpasson commented Mar 25, 2024

Added failing test and fix or issue #646

@cowtowncoder
Copy link
Member

Looks good!

Before merging, one (and only) process thing: unless I've asked (and gotten) CLA, we'd need one from:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

before merging the PR. Only needs to be done once & is good for perpetuity.
The usual way is to print, fill & sign, scan/photo, email to cla at fasterxml dot com.
And once we have it, can go ahead and merge this fix.

Thank you once again for contributing this!

@bpasson
Copy link
Contributor Author

bpasson commented Mar 25, 2024

@cowtowncoder you should have it shortly.

@cowtowncoder cowtowncoder merged commit ad486b3 into FasterXML:2.17 Mar 26, 2024
4 checks passed
@cowtowncoder
Copy link
Member

CLA received, pr merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants